feat: add temporary message alert in sections settings tab in libraries#2734
feat: add temporary message alert in sections settings tab in libraries#2734ChrisChV merged 3 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2734 +/- ##
========================================
Coverage 94.90% 94.90%
========================================
Files 1235 1235
Lines 28260 28260
Branches 6433 6227 -206
========================================
Hits 26819 26819
- Misses 1370 1383 +13
+ Partials 71 58 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
14c9852 to
1426176
Compare
Also increase sidebar width to remove `More` option and display all tabs together
3f1804a to
4344b90
Compare
…Info.tsx Co-authored-by: Chris Chávez <[email protected]>
4344b90 to
52ff936
Compare
There was a problem hiding this comment.
Looks good 👍
- I tested this: I followed the testing insturctions
- I read through the code and considered the security, stability and performance implications of the changes.
- I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
- Includes tests for bugfixes and/or features added.
|
@navinkarkera merged, Is this a fix that needs to be backported? |
…es (openedx#2734) - add temporary message alert in sections settings tab in libraries - increase sidebar width to remove `More` option and display all tabs together (cherry picked from commit 3eeca24)
…es (openedx#2734) (openedx#2766) - add temporary message alert in sections settings tab in libraries - increase sidebar width to remove `More` option and display all tabs together (cherry picked from commit 3eeca24)
* fix: support "in progress" status for lib upload When uploading a library archive file during the creation of a new library, the code prior to this commit did not properly handle the "In Progress" state, which is when the celery task doing the archive processing is actively running. Note that this is distinct from the "Pending" state, which is when the task is waiting in the queue to be run (which in practice should almost never happen unless there is an operational issue). Since celery tasks run in-process during local development, the task was always finished by the time that the browser made a call to check on the status. The problem only happened on slower sandboxes, where processing truly runs asynchronously and might take a few seconds. Because this case wasn't handled, the frontend would never poll for updates either, so the upload was basically lost as far as the user was concerned. * feat: add temporary message alert in sections settings tab in libraries (openedx#2734) (openedx#2766) - add temporary message alert in sections settings tab in libraries - increase sidebar width to remove `More` option and display all tabs together (cherry picked from commit 3eeca24) --------- Co-authored-by: David Ormsbee <[email protected]> Co-authored-by: Navin Karkera <[email protected]>
Description
Also increase sidebar width to remove
Moreoption and display all tabstogether
Supporting information
Testing instructions
Verify the alert message in settings tab of sections sidebar in library.
Other information
Include anything else that will help reviewers and consumers understand the change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'