Skip to content

feat: add temporary message alert in sections settings tab in libraries#2734

Merged
ChrisChV merged 3 commits intoopenedx:masterfrom
open-craft:navin/settings-tab
Dec 17, 2025
Merged

feat: add temporary message alert in sections settings tab in libraries#2734
ChrisChV merged 3 commits intoopenedx:masterfrom
open-craft:navin/settings-tab

Conversation

@navinkarkera
Copy link
Copy Markdown
Contributor

@navinkarkera navinkarkera commented Dec 5, 2025

Description

Also increase sidebar width to remove More option and display all tabs
together

image

Supporting information

Testing instructions

Verify the alert message in settings tab of sections sidebar in library.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Dec 5, 2025
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @navinkarkera!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.90%. Comparing base (42acb53) to head (52ff936).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2734    +/-   ##
========================================
  Coverage   94.90%   94.90%            
========================================
  Files        1235     1235            
  Lines       28260    28260            
  Branches     6433     6227   -206     
========================================
  Hits        26819    26819            
- Misses       1370     1383    +13     
+ Partials       71       58    -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/library-authoring/containers/ContainerInfo.tsx Outdated
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Dec 11, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Dec 11, 2025
Also increase sidebar width to remove `More` option and display all tabs
together
Copy link
Copy Markdown
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

  • I tested this: I followed the testing insturctions
  • I read through the code and considered the security, stability and performance implications of the changes.
  • I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
  • Includes tests for bugfixes and/or features added.

@ChrisChV ChrisChV merged commit 3eeca24 into openedx:master Dec 17, 2025
7 checks passed
@github-project-automation github-project-automation Bot moved this from In Eng Review to Done in Contributions Dec 17, 2025
@ChrisChV
Copy link
Copy Markdown
Contributor

@navinkarkera merged, Is this a fix that needs to be backported?

navinkarkera added a commit to open-craft/frontend-app-authoring that referenced this pull request Dec 19, 2025
…es (openedx#2734)

- add temporary message alert in sections settings tab in libraries
- increase sidebar width to remove `More` option and display all tabs
together

(cherry picked from commit 3eeca24)
@navinkarkera
Copy link
Copy Markdown
Contributor Author

@ChrisChV Created: #2766

@bradenmacdonald bradenmacdonald deleted the navin/settings-tab branch December 20, 2025 00:35
bradenmacdonald pushed a commit that referenced this pull request Dec 20, 2025
…es (#2734) (#2766)

- add temporary message alert in sections settings tab in libraries
- increase sidebar width to remove `More` option and display all tabs
together

(cherry picked from commit 3eeca24)
viv-helix pushed a commit to edx/frontend-app-authoring that referenced this pull request Mar 9, 2026
…es (openedx#2734) (openedx#2766)

- add temporary message alert in sections settings tab in libraries
- increase sidebar width to remove `More` option and display all tabs
together

(cherry picked from commit 3eeca24)
viv-helix added a commit to edx/frontend-app-authoring that referenced this pull request Mar 20, 2026
* fix: support "in progress" status for lib upload

When uploading a library archive file during the creation of a new
library, the code prior to this commit did not properly handle the "In
Progress" state, which is when the celery task doing the archive
processing is actively running. Note that this is distinct from the
"Pending" state, which is when the task is waiting in the queue to be
run (which in practice should almost never happen unless there is an
operational issue).

Since celery tasks run in-process during local development, the task
was always finished by the time that the browser made a call to check
on the status. The problem only happened on slower sandboxes, where
processing truly runs asynchronously and might take a few seconds.
Because this case wasn't handled, the frontend would never poll for
updates either, so the upload was basically lost as far as the user
was concerned.

* feat: add temporary message alert in sections settings tab in libraries (openedx#2734) (openedx#2766)

- add temporary message alert in sections settings tab in libraries
- increase sidebar width to remove `More` option and display all tabs
together

(cherry picked from commit 3eeca24)

---------

Co-authored-by: David Ormsbee <[email protected]>
Co-authored-by: Navin Karkera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants