feat: remove "Create Zendesk Tickets for suspicious attempts" setting from Proctored Exam Settings#2517
Conversation
Skipped tests related to Zendesk ticket functionality due to proctortrack provider deprecation.
Skip tests related to proctortrack provider updates.
Updated tests to skip those related to Proctortrack deprecation.
Updated test to skip due to Proctortrack deprecation and changed selector for escalation email input.
Removed tests related to Proctortrack due to its deprecation.
…rom Proctored Exam Settings
Removed 'create_zendesk_tickets' from proctored exam settings in tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2517 +/- ##
========================================
Coverage 94.89% 94.89%
========================================
Files 1235 1235
Lines 28254 28254
Branches 6223 6412 +189
========================================
Hits 26813 26813
Misses 1383 1383
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Removed the 'create_zendesk_tickets' property from the settings object in the test.
Add logic to set form values and show escalation email based on proctoring provider selection.
michaelroytman
left a comment
There was a problem hiding this comment.
I left one comment. After we've discussed and addressed that, I think this will be good to go.
Removed createZendeskTickets from form values.
kdmccormick
left a comment
There was a problem hiding this comment.
Thanks for this work! I grepped for "zendesk" and "Zendesk" and still found ~8 more occurrences, can you do the same and remove those references too?
|
Please hit "Ready for Review" and re-request my review when you're ready Santhosh. |
Done |
kdmccormick
left a comment
There was a problem hiding this comment.
Did you forget to push? There are still zendesk references remaining in the repo.
Just wanted to confirm, the Zendesk references mentioned here, are they specifically related to ProctorTrack, or are they general/independent references? |
|
@kdmccormick |
kdmccormick
left a comment
There was a problem hiding this comment.
Ah @santhosh-apphelix-2u , I see: the AccessibilityForm also calls zendesk_proxy, and we did not agree to remove that. Good call, we can leave all the Zendesk references under src/accessibility-page as-is.
However, there are proctoring-related references to create_zendesk_tickets and createZendeskTickets in plugins/course-apps/proctoring/Settings.test.jsx , src/course-outline/__mocks__/courseOutlineIndex.js , and src/course-unit/__mocks__/courseSectionVertical.js. These are just adding test data which is now useless since create_zendesk_tickets has been disabled. Can you remove those?
Lastly, the README still states that the proctoring integration can create Zendesk tickets, which is no longer true. Can you update that as well?
Thanks!
|
Hey @santhosh-apphelix-2u , we have just merged #2645, so I think you can rebase this now without worry about future merge conflicts. |
|
@santhosh-apphelix-2u friendly reminder about this PR :) |
|
I'm currently looking into the remaining changes and will update the PR shortly. |
Refactor proctoring provider logic to handle escalation email visibility based on a list of providers.
Refactor proctoring provider logic to improve clarity.
This PR removes the deprecated “Create Zendesk Tickets for suspicious attempts” setting from the Proctored Exam Settings modal in the
frontend-app-authoringMFE.This option was previously used with PSI and Zendesk to generate support tickets for suspicious exam attempts. Since both systems are retired, the setting no longer serves a purpose and has been fully removed.
Technical Changes Made
1.
plugins/course-apps/proctoring/Settings.jsxcreateZendeskTicketsfrominitialFormValueshandleChangeto drop references tocreateZendeskTicketssoftware_secureprovidercreate_zendesk_ticketsfrom the API payload (studioDataToPostBack)Form.Group,Form.RadioSet) that rendered the Yes/No radio buttons2.
plugins/course-apps/proctoring/Settings.test.jsxcreateZendeskTicketsUI elements and payloadsallowOptingOutbehavior3.
plugins/course-apps/proctoring/messages.jsauthoring.proctoring.createzendesk.labelRef - https://2u-internal.atlassian.net/browse/COSMO2-27