chore: Refactor proctoring provider handling in Settings#2494
Closed
santhosh-apphelix-2u wants to merge 9 commits intoopenedx:masterfrom
Closed
chore: Refactor proctoring provider handling in Settings#2494santhosh-apphelix-2u wants to merge 9 commits intoopenedx:masterfrom
santhosh-apphelix-2u wants to merge 9 commits intoopenedx:masterfrom
Conversation
Skipped tests related to Zendesk ticket functionality due to proctortrack provider deprecation.
Skip tests related to proctortrack provider updates.
Updated tests to skip those related to Proctortrack deprecation.
Updated test to skip due to Proctortrack deprecation and changed selector for escalation email input.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2494 +/- ##
========================================
Coverage 94.68% 94.68%
========================================
Files 1203 1203
Lines 26865 26865
Branches 6026 5876 -150
========================================
Hits 25438 25438
- Misses 1357 1368 +11
+ Partials 70 59 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Removed tests related to Proctortrack due to its deprecation.
jcapphelix
approved these changes
Oct 6, 2025
jcapphelix
left a comment
jcapphelix
left a comment
There was a problem hiding this comment.
Good to go for further approvals.
Closed
17 tasks
kdmccormick
requested changes
Oct 6, 2025
| }); | ||
|
|
||
| it(`Creates an alert when invalid proctoring escalation email is provided with ${provider} selected`, async () => { | ||
| // Test skipped due to Proctortrack deprecation |
Member
There was a problem hiding this comment.
Why are we disabling this test?
| }); | ||
|
|
||
| it('Makes API call successfully with proctoring_escalation_email if proctortrack', async () => { | ||
| await act(async () => render(intlWrapper(<IntlProctoredExamSettings {...defaultProps} />))); |
Member
There was a problem hiding this comment.
Why are we disabling this test now?
Member
|
I believe this can be closed in favor of: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the conditional block that handled
value === 'proctortrack', which explicitly setcreateZendeskTicketstofalseand enabled escalation email. As part of Proctortrackdeprecation, this clause is no longer needed. By default,
createZendeskTicketsis alreadyset to false, and Zendesk tickets are unrelated to Proctortrack.