Skip to content

crypto: reject unintended raw key format string input #62974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panva wants to merge 2 commits into
base: main
Choose a base branch
from
+45 −1
Open

crypto: reject unintended raw key format string input #62974

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce3e203
crypto: reject unintended raw key format string input
panva Apr 26, 2026
2682a82
Update test/parallel/test-crypto-key-objects-raw.js
panva Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/crypto/keys.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ function prepareAsymmetricKey(key, ctx, name = 'key') {
return { data, format: kKeyFormatJWK };
} else if (format === 'raw-public' || format === 'raw-private' ||
format === 'raw-seed') {
if (!isStringOrBuffer(data)) {
if (!isArrayBufferView(data) && !isAnyArrayBuffer(data)) {
throw new ERR_INVALID_ARG_TYPE(
`${name}.key`,
['ArrayBuffer', 'Buffer', 'TypedArray', 'DataView'],
Expand Down
44 changes: 44 additions & 0 deletions test/parallel/test-crypto-key-objects-raw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,50 @@ const { hasOpenSSL } = require('../common/crypto');
}
}

// Raw key imports do not support strings.
{
const pubKeyObj = crypto.createPublicKey(
fixtures.readKey('ed25519_public.pem', 'ascii'));
const privKeyObj = crypto.createPrivateKey(
fixtures.readKey('ed25519_private.pem', 'ascii'));

const rawPub = pubKeyObj.export({ format: 'raw-public' });
const rawPriv = privKeyObj.export({ format: 'raw-private' });

for (const encoding of ['hex', 'base64']) {
Comment thread
panva marked this conversation as resolved.
Outdated
assert.throws(() => crypto.createPublicKey({
key: rawPub.toString(encoding),
encoding,
format: 'raw-public',
asymmetricKeyType: 'ed25519',
}), { code: 'ERR_INVALID_ARG_TYPE' });

assert.throws(() => crypto.createPrivateKey({
key: rawPriv.toString(encoding),
encoding,
format: 'raw-private',
asymmetricKeyType: 'ed25519',
}), { code: 'ERR_INVALID_ARG_TYPE' });
}
}

// Raw seed imports do not support strings.
if (hasOpenSSL(3, 5)) {
const privKeyObj = crypto.createPrivateKey(
fixtures.readKey('ml_dsa_44_private.pem', 'ascii'));

const rawSeed = privKeyObj.export({ format: 'raw-seed' });

for (const encoding of ['hex', 'base64']) {
assert.throws(() => crypto.createPrivateKey({
key: rawSeed.toString(encoding),
encoding,
format: 'raw-seed',
asymmetricKeyType: 'ml-dsa-44',
}), { code: 'ERR_INVALID_ARG_TYPE' });
}
}

// Key types that don't support raw-* formats
{
for (const [type, pub, priv] of [
Expand Down
Loading