Skip to content

crypto: reject unintended raw key format string input#62974

Open
panva wants to merge 2 commits intonodejs:mainfrom
panva:raw-format-strings
Open

crypto: reject unintended raw key format string input#62974
panva wants to merge 2 commits intonodejs:mainfrom
panva:raw-format-strings

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Apr 26, 2026

As originally intended, raw formats !== strings.

@panva panva requested a review from ChALkeR April 26, 2026 14:48
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 26, 2026
@panva panva added the lts-watch-v24.x PRs that may need to be released in v24.x label Apr 26, 2026
Comment thread test/parallel/test-crypto-key-objects-raw.js Outdated
@panva panva added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 26, 2026
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 26, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.64%. Comparing base (21436f0) to head (2682a82).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62974      +/-   ##
==========================================
- Coverage   89.66%   89.64%   -0.02%     
==========================================
  Files         706      706              
  Lines      219391   219409      +18     
  Branches    42068    42079      +11     
==========================================
- Hits       196712   196699      -13     
- Misses      14578    14613      +35     
+ Partials     8101     8097       -4     
Files with missing lines Coverage Δ
lib/internal/crypto/keys.js 96.90% <100.00%> (ø)

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. crypto Issues and PRs related to the crypto subsystem. lts-watch-v24.x PRs that may need to be released in v24.x needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants