util: refactor filterDuplicateStrings for readability

[Ayoub-Mabrouk]

Modernize filterDuplicateStrings by using for-of loop and ternary
operator for cleaner, more idiomatic ES2018 code.

Changes:

• Replace traditional for loop with for-of iteration
• Consolidate conditional map.set() using ternary operator
• Eliminate iterator variable reducing cognitive complexity

No functional changes, performance remains equivalent.

[ex1st]

Hi @Ayoub-Mabrouk as I know, the Node.js team is trying to avoid the for-of iteration. Please check https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration

[Ayoub-Mabrouk]

Hi @Ayoub-Mabrouk as I know, the Node.js team is trying to avoid the for-of iteration. Please check https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration

Thanks alot 🙏👌

[ljharb]

for-of is much slower than a for loop.

[Ayoub-Mabrouk]

for-of is much slower than a for loop.

Thanks for the feedback

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

[github-actions]

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.