[SM6.10][HLK] Add LinAlg execution test infrastructure with Load/Store/Splat tests by V-FEXrt · Pull Request #8285 · microsoft/DirectXShaderCompiler

V-FEXrt · 2026-03-20T22:55:01Z

Introduce LinAlgTests.cpp with a new pattern for execution tests where ShaderOp objects are built programmatically in C++ no ShaderOpArith.xml entries required. Shader source, resources, and root signatures are all defined in the .cpp file.

Tests will currently be skipped since no driver reports SM6.10 support

Co-authored-by: Copilot [email protected]

Introduce LinAlgTests.cpp with a new pattern for execution tests where ShaderOp objects are built programmatically in C++ no ShaderOpArith.xml entries required. Shader source, resources, and root signatures are all defined in the .cpp file. Each test compiles its shader via IDxcCompiler3 to validate the HLSL, then skips GPU dispatch if no SM 6.10 device is available. This ensures shader authoring correctness is always verified. Tests added: - LoadStoreRoundtrip_Wave_F32/I32: MatrixLoadFromDescriptor + MatrixStoreToDescriptor - SplatStore_Wave_F32/I32: FillMatrix + MatrixStoreToDescriptor Co-authored-by: Copilot <[email protected]>

github-actions · 2026-03-20T22:55:50Z

✅ With the latest revision this PR passed the C/C++ code formatter.

alsepkow

Adding some comments

alsepkow · 2026-03-21T00:56:38Z

+  }
+
+  std::vector<float> ExpectedFloats(NumElements, FillValue);
+  std::vector<int32_t> ExpectedInts(NumElements,


nit: this cast could UB

alsepkow · 2026-03-21T00:58:51Z

+
+  auto Op =
+      createComputeOp(SplatStoreShader, "cs_6_10", "UAV(u0)", Args.c_str());
+  addUAVBuffer(Op.get(), "Output", BufferSize, true);


nit: We may want to consider adding addUAVBuffer and others to HLSLExecTestUtils.
And there may be potential to update the ShaderOpTest.cpp code to use those helpers.

For this PR I think just putting these generic helpers in HLSLExecTestUtils would be a good first step. They're likely to be useful for future tests looking to follow the same patterns in these tests.

- Remove NOMINMAX block (not needed without std::min/max + windows.h) - Remove 'Unlike older execution tests...' paragraph from file header - Convert block comments to /// doc comment style - Remove unhelpful 'Always initialize DXC compiler' comment - Apply clang-format fixes Co-authored-by: Copilot <[email protected]>

- Replace custom ComponentType/MatrixUse/MatrixScope/MatrixLayout enums with hlsl::DXIL types from DxilConstants.h - Add elemSize() helper to eliminate duplicated element size logic in strideBytes() and totalBytes() - Make buildCompilerArgs take const MatrixParams& instead of individual params - Use switch statements for CompType dispatch instead of if-else chains Co-authored-by: Copilot <[email protected]>

- Update setupClass with SkipUnsupported variable and more informative error message following existing HLK test patterns - Update setupMethod with robust device-loss detection and recreation that fails hard (VERIFY) since a working device existed previously - Fix potential UB in runSplatStore by only constructing the expected int vector when CompType is I32 (avoids unconditional float-to-int cast) Co-authored-by: Copilot <[email protected]>

hekota · 2026-03-24T05:40:11Z

+/// Return the byte size of a single element for the given component type.
+static int elemSize(ComponentType CT) {
+  switch (CT) {
+  case ComponentType::F16:


How about the 8-bit component types I8, U8, F8_E4M3 and F8_E5M2?

These are just the first pass of tests, not the final ones! Planning on adding a lot more detailed tests after getting the basic tests/test framework in

Co-authored-by: Alex Sepkowski <[email protected]> Co-authored-by: Ashley Coleman <[email protected]>

alsepkow · 2026-03-25T18:59:08Z

+  Buf.Size = SourceBlob->GetBufferSize();
+  Buf.Encoding = DXC_CP_UTF8;
+
+  CComPtr<IDxcResult> Result;


nit: Don't have to add it this PR. But it might be helpful to log the arguments being passed to the compiler.

alsepkow · 2026-03-25T19:19:52Z

+
+private:
+  bool createDevice();
+


Suggested change

WEX::TestExecution::SetVerifyOutput VerifyOutput{

WEX::TestExecution::VerifyOutputSettings::LogOnlyFailures};

If you add this member variable it will cut down on the logging of every single verify macro and instead only log it on a failure.

alsepkow · 2026-03-25T19:22:42Z

+    ExpectedFloats.assign(NumElements, FillValue);
+    break;
+  case ComponentType::I32:
+    ExpectedInts.assign(NumElements, static_cast<int32_t>(FillValue));


nit: this could still potentially produce UB if FillValue can't be represented as an int32. Not a problem right now. But we'll probably want to consider bounds checking on values somewhere at some point to prevent this.

oh right! I forgot about our discussion here!

alsepkow

LGTM. A few comments I'm ok being addressed on a subsequent change if you want.

V-FEXrt · 2026-03-25T20:54:24Z

Sounds good! I'm going to add the remaining comments to the ticket for this work item and we can circle back around to resolve them! I'd like to get something merged so we can have a couple tests landed

github-project-automation Bot added this to HLSL Roadmap Mar 20, 2026

github-project-automation Bot moved this to New in HLSL Roadmap Mar 20, 2026

V-FEXrt requested review from alsepkow and damyanp March 20, 2026 22:55

alsepkow reviewed Mar 21, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/LinAlgTests.cpp Outdated

alsepkow reviewed Mar 21, 2026

View reviewed changes

damyanp reviewed Mar 21, 2026

View reviewed changes

damyanp and others added 2 commits March 23, 2026 10:35

V-FEXrt commented Mar 23, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/LinAlgTests.cpp Outdated

V-FEXrt commented Mar 23, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/LinAlgTests.cpp

V-FEXrt commented Mar 23, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/LinAlgTests.cpp

V-FEXrt commented Mar 23, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/LinAlgTests.cpp

damyanp and others added 2 commits March 23, 2026 14:51

format

86d2815

damyanp reviewed Mar 23, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/LinAlgTests.cpp Outdated

damyanp reviewed Mar 23, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/LinAlgTests.cpp Outdated

damyanp approved these changes Mar 23, 2026

View reviewed changes

V-FEXrt added 3 commits March 23, 2026 16:45

cleanup

00a8237

comments

7a1b4f4

format

a0e480d

damyanp approved these changes Mar 24, 2026

View reviewed changes

hekota reviewed Mar 24, 2026

View reviewed changes

V-FEXrt added 4 commits March 24, 2026 09:56

Address comments

0254507

Address comments

a576b21

Fix tests being skipped too early

bf8578c

Cleaup dupe code

b813448

alsepkow reviewed Mar 25, 2026

View reviewed changes

V-FEXrt commented Mar 25, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/LinAlgTests.cpp Outdated

V-FEXrt commented Mar 25, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/LinAlgTests.cpp Outdated

V-FEXrt commented Mar 25, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/LinAlgTests.cpp Outdated

V-FEXrt commented Mar 25, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/LinAlgTests.cpp Outdated

V-FEXrt commented Mar 25, 2026

View reviewed changes

Comment thread tools/clang/unittests/HLSLExec/LinAlgTests.cpp Outdated

V-FEXrt and others added 4 commits March 25, 2026 10:07

Apply suggestions from code review

6dd3b4f

Co-authored-by: Alex Sepkowski <[email protected]> Co-authored-by: Ashley Coleman <[email protected]>

Fix build

87b7471

Merge branch 'main' into linalg-basic-hlk

58fe8f6

Fix shader compiler error

a647ba2

alsepkow reviewed Mar 25, 2026

View reviewed changes

alsepkow approved these changes Mar 25, 2026

View reviewed changes

V-FEXrt mentioned this pull request Mar 25, 2026

Create Basic LinAlg Matrix HLKs #8126

Closed

V-FEXrt merged commit 80ffa2e into microsoft:main Mar 25, 2026
12 checks passed

github-project-automation Bot moved this from New to Done in HLSL Roadmap Mar 25, 2026

V-FEXrt deleted the linalg-basic-hlk branch March 25, 2026 21:12

Copilot AI mentioned this pull request Mar 26, 2026

Resolve merge conflicts for microsoft/DirectXShaderCompiler PR #8291 damyanp/DirectXShaderCompiler#12

Merged


	WEX::TestExecution::SetVerifyOutput VerifyOutput{
	WEX::TestExecution::VerifyOutputSettings::LogOnlyFailures};

Conversation

V-FEXrt commented Mar 20, 2026

Uh oh!

github-actions Bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

alsepkow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alsepkow left a comment

Choose a reason for hiding this comment

Uh oh!

V-FEXrt commented Mar 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Mar 20, 2026 •

edited

Loading