[0029] [Main] For OuterProductAccumulate, matrix layout must be outerproductoptimal and matrix stride must be zero #7417
Merged
damyanp merged 17 commits intomicrosoft:mainfrom May 13, 2025
Conversation
… layout -> matrix stride
anupamachandra
commented
May 2, 2025
anupamachandra
commented
May 2, 2025
damyanp
approved these changes
May 2, 2025
tex3d
reviewed
May 2, 2025
tex3d
requested changes
May 2, 2025
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
I'm requesting changes due to the DxilValidation test being in the wrong form in the wrong place.
Member
|
This LGTM still. @tex3d - please merge when you're ready to approve. |
tex3d
reviewed
May 9, 2025
Contributor
There was a problem hiding this comment.
No tests are automatically run from this location (CodeGenHLSL). It is a path containing test content for explicit reference by TAEF tests.
This test should be under the CodeGenDXIL folder, I believe.
bob80905
approved these changes
May 12, 2025
Collaborator
bob80905
left a comment
bob80905
left a comment
There was a problem hiding this comment.
In the interest of time I think this could go in as is, though small improvements in clarity are possible.
bob80905
approved these changes
May 12, 2025
tex3d
approved these changes
May 12, 2025
…-acc-matrix-layout-main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retargets #7412 to main branch