For OuterProductAccumulate, matrix layout must be outerproductoptimal and matrix stride must be zero #7412
Closed
anupamachandra wants to merge 7 commits intomicrosoft:staging-sm6.9from
Conversation
damyanp
reviewed
May 1, 2025
Comment on lines
+11
to
+44
| enum CompType { | ||
| Invalid = 0, | ||
| I1 = 1, | ||
| I16 = 2, | ||
| U16 = 3, | ||
| I32 = 4, | ||
| U32 = 5, | ||
| I64 = 6, | ||
| U64 = 7, | ||
| F16 = 8, | ||
| F32 = 9, | ||
| F64 = 10, | ||
| SNormF16 = 11, | ||
| UNormF16 = 12, | ||
| SNormF32 = 13, | ||
| UNormF32 = 14, | ||
| SNormF64 = 15, | ||
| UNormF64 = 16, | ||
| PackedS8x32 = 17, | ||
| PackedU8x32 = 18, | ||
|
|
||
| // BEGIN NEW FOR SM 6.9 | ||
| U8 = 19, | ||
| I8 = 20, | ||
| F8_E4M3 = 21, | ||
| F8_E5M2 = 22, | ||
| }; | ||
|
|
||
| enum MatLayout { | ||
| RowMajor = 0, | ||
| ColumnMajor = 1, | ||
| MulOptimal = 2, | ||
| OuterProductOptimal = 3, | ||
| }; |
Member
There was a problem hiding this comment.
I'm not super keen on having the full enums duplicated here. I may have missed a discussion about it though...
Since only one value is could we instead do something like:
const uint matrix_interpretation = 8; // ComponentType::F16;That way grepping through the source code will find the right things.
Collaborator
Author
|
Opened a new PR targetting master branch: #7417 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the DXIL portion of microsoft/hlsl-specs#494, The HLSL checks will be a part of the HLSL validation checks, did not add it to this PR due to shared infrastructure.