Add HctGen of DXIL.rst back to build without LLVM_BUILD_DOCS required#7346
Merged
tex3d merged 2 commits intomicrosoft:mainfrom Apr 15, 2025
Merged
Add HctGen of DXIL.rst back to build without LLVM_BUILD_DOCS required#7346tex3d merged 2 commits intomicrosoft:mainfrom
tex3d merged 2 commits intomicrosoft:mainfrom
Conversation
damyanp
approved these changes
Apr 15, 2025
Member
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
Seems like this is something we'd want to have happen as a matter of course. Nice catch!
HctGen of DXIL.rst should happen on every ordinary build, and be updated with other HctGen modified files. This isn't about building the doc, it's about updating it when definitions change in hctdb.py. This also brings DXIL.rst up to date. We've been missing updates to DXIL.rst for quite a while due to this issue.
tex3d
force-pushed
the
add-dxil-rst-to-hctgen
branch
from
9318582 to
c362750
Compare
llvm-beanz
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HctGen of DXIL.rst should happen on every ordinary build, and be updated with other HctGen modified files.
This isn't about building the doc, it's about updating it when definitions change in hctdb.py.
We've been missing updates to DXIL.rst for quite a while due to this issue, introduced here.
This also brings DXIL.rst up to date.