Skip to content

[OMM] Add D3D Flag RAYTRACING_PIPELINE_FLAG_ALLOW_OPACITY_MICROMAPS, and run d3dreflect tests#7239

Merged
bob80905 merged 13 commits intomicrosoft:mainfrom
bob80905:OMMreflect00
Mar 28, 2025
Merged

[OMM] Add D3D Flag RAYTRACING_PIPELINE_FLAG_ALLOW_OPACITY_MICROMAPS, and run d3dreflect tests#7239
bob80905 merged 13 commits intomicrosoft:mainfrom
bob80905:OMMreflect00

Conversation

@bob80905
Copy link
Copy Markdown
Collaborator

@bob80905 bob80905 commented Mar 20, 2025 •
edited
Loading

This PR adds a new flag, RAYTRACING_PIPELINE_FLAG_ALLOW_OPACITY_MICROMAPS, according to the spec.
It can be used with RaytracingPipelineConfig1 subobjects. We expect this new flag to be represented in the output.
Additionally, d3dreflect tests are run to ensure that when a rayquery object is using the new OMM enablement flags, that
the minimum shader model target is 6.9.

Fixes #7190

@bob80905 bob80905 requested a review from a team as a code owner March 20, 2025 23:10
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

damyanp
damyanp approved these changes Mar 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To My Untrained Eye

tex3d
tex3d reviewed Mar 21, 2025
View reviewed changes
Comment thread tools/clang/test/HLSLFileCheck/d3dreflect/rayquery-reflection.hlsl Outdated
tex3d
tex3d reviewed Mar 21, 2025
View reviewed changes
Comment thread tools/clang/test/HLSLFileCheck/d3dreflect/rayquery-reflection.hlsl Outdated
tex3d
tex3d reviewed Mar 21, 2025
View reviewed changes
Comment thread tools/clang/lib/AST/ASTContextHLSL.cpp
@bob80905 bob80905 mentioned this pull request Mar 25, 2025
Merged
bob80905 added a commit that referenced this pull request Mar 27, 2025
@bob80905
[Sema] Add and test new Subobject Attribute (#7258)
5ff9cbc 
This PR adds and tests a new subobject attribute. It will be useful for
checking if a given decl is a subobject decl. This functionality will be
used in #7239
We need an attribute in order to determine whether to check its
initializer for availability attributes or not.

Fixes #7257
@damyanp damyanp added this to the Next Release milestone Mar 28, 2025
tex3d
tex3d reviewed Mar 28, 2025
View reviewed changes
Comment thread tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp Outdated
tex3d
tex3d reviewed Mar 28, 2025
View reviewed changes
Comment thread tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp
tex3d
tex3d reviewed Mar 28, 2025
View reviewed changes
Comment thread tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp
tex3d
tex3d reviewed Mar 28, 2025
View reviewed changes
Comment thread tools/clang/lib/Sema/SemaHLSLDiagnoseTU.cpp Outdated
@bob80905 bob80905 merged commit 206b775 into microsoft:main Mar 28, 2025
12 checks passed
@github-project-automation github-project-automation Bot moved this from New to Done in HLSL Roadmap Mar 28, 2025
@damyanp damyanp moved this to Closed in HLSL Support Apr 25, 2025
@damyanp damyanp removed this from HLSL Support Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tex3d tex3d tex3d approved these changes

@damyanp damyanp damyanp approved these changes

Assignees

@tex3d tex3d

Labels

None yet

Projects

HLSL Roadmap
Archived in project

Milestone

May 2025 Release

Development

Successfully merging this pull request may close these issues.

[OMM] Create d3dreflect tests for OMM functionality

3 participants

@bob80905 @tex3d @damyanp