Skip to content

[DO NOT MERGE] Update clang-format-checker.yml #7222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alsepkow wants to merge 4 commits into from
Closed

[DO NOT MERGE] Update clang-format-checker.yml #7222

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
809d2ae
Update clang-format-checker.yml
alsepkow Mar 18, 2025
e8d3fe7
Merge branch 'main' into user/alsepkow/UpdateGitHubActions
alsepkow Mar 18, 2025
8f75477
Fetch last 100 commits for LLVM sources
alsepkow Mar 18, 2025
dedd923
Revert chris's change to see
alsepkow Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/clang-format-checker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,16 @@ jobs:
- name: Fetch LLVM sources
uses: actions/checkout@v4
with:
fetch-depth: 2
repository: ${{ github.event.pull_request.head.repo.full_name }}
fetch-depth: 0 # Fetch all history

- name: Get changed files
id: changed-files
uses: step-security/changed-files@3dbe17c78367e7d60f00d78ae6781a35be47b4a1 # v45.0.1
uses: tj-actions/changed-files@v41
Copy link
Copy Markdown
Collaborator

@llvm-beanz llvm-beanz Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was deliberate in #7217 because the tj-actions version of the action had a significant security vulnerability.

I'm not sure what the correct fix is, but we should not revert back to the tj-actions version.

Copy link
Copy Markdown
Contributor Author

@alsepkow alsepkow Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely was not intending to check this in. Initially didn't think everyone would see the PR if it was marked as a draft.

with:
separator: ","
skip_initial_fetch: true
# skip_initial_fetch: true
fetch_depth: 100 # Fetches only the last 100 commits

- name: "Listed files"
env:
Expand Down Expand Up @@ -88,7 +90,8 @@ jobs:
- name: Fetch LLVM sources
uses: actions/checkout@v4
with:
fetch-depth: 2
repository: ${{ github.event.pull_request.head.repo.full_name }}
fetch-depth: 0 # Fetch all history
path: build/main_src

- name: Setup Python env
Expand All @@ -115,7 +118,7 @@ jobs:
- name: Fetch LLVM sources for head
uses: actions/checkout@v4
with:
fetch-depth: 2
fetch-depth: 0 # Fetch all history
ref: ${{ fromJSON(steps.get-pr.outputs.result).head.ref }}
repository: ${{ fromJSON(steps.get-pr.outputs.result).head.repo.full_name }}

Expand Down
Loading