Skip to content

[DO NOT MERGE] Update clang-format-checker.yml#7222

Closed
alsepkow wants to merge 4 commits intomicrosoft:mainfrom
alsepkow:user/alsepkow/UpdateGitHubActions
Closed

[DO NOT MERGE] Update clang-format-checker.yml#7222
alsepkow wants to merge 4 commits intomicrosoft:mainfrom
alsepkow:user/alsepkow/UpdateGitHubActions

Conversation

@alsepkow
Copy link
Copy Markdown
Contributor

The github action for clang-format-checker started failing with "Error: Similar commit hashes detected: previous sha: 3ddf29b is equivalent to the current sha: 3ddf29b."

- name: Get changed files
id: changed-files
uses: step-security/changed-files@3dbe17c78367e7d60f00d78ae6781a35be47b4a1 # v45.0.1
uses: tj-actions/changed-files@v41
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was deliberate in #7217 because the tj-actions version of the action had a significant security vulnerability.

I'm not sure what the correct fix is, but we should not revert back to the tj-actions version.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely was not intending to check this in. Initially didn't think everyone would see the PR if it was marked as a draft.

@alsepkow alsepkow closed this Mar 18, 2025
@github-project-automation github-project-automation Bot moved this from New to Done in HLSL Roadmap Mar 18, 2025
@alsepkow alsepkow changed the title Update clang-format-checker.yml [DO NOT MERGE] Update clang-format-checker.yml Mar 18, 2025
@alsepkow alsepkow deleted the user/alsepkow/UpdateGitHubActions branch June 10, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants