Skip to content

Fix flaky int-test failure by making NettyClient response queue thread-safe #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix flaky int-test failure by making NettyClient response queue thread-safe #3282

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75e83e1
Initial plan
Copilot Aug 12, 2026
8a128fc
Use concurrent queue for NettyClient response parts
Copilot Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ambry-test-utils/src/main/java/com/github/ambry/rest/NettyClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
import io.netty.util.ReferenceCountUtil;
import io.netty.util.concurrent.GenericFutureListener;
import java.io.Closeable;
import java.util.LinkedList;
import java.util.Queue;
import java.util.concurrent.ConcurrentLinkedQueue;
import java.util.concurrent.Future;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
Expand All @@ -57,7 +57,7 @@ public class NettyClient implements Closeable {

private final EventLoopGroup group = new NioEventLoopGroup();
private final Bootstrap b = new Bootstrap();
private final Queue<HttpObject> responseParts = new LinkedList<HttpObject>();
private final Queue<HttpObject> responseParts = new ConcurrentLinkedQueue<HttpObject>();
private final AtomicBoolean callbackInvoked = new AtomicBoolean(false);
private final RequestSender requestSender = new RequestSender();
private final WriteResultListener writeResultListener = new WriteResultListener();
Expand Down