Draft
Fix flaky int-test failure by making NettyClient response queue thread-safe#3282
int-test failure by making NettyClient response queue thread-safe#3282Conversation
Co-authored-by: beijxu <[email protected]>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job
Fix flaky Aug 12, 2026
int-test failure by making NettyClient response queue thread-safe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This addresses the intermittent failure in
Github Actions CI / int-test (pull_request)whereFrontendIntegrationTestcould throwIllegalStateException(Should have received response...) after request completion.Root cause was cross-thread access to
NettyClient.responsePartsusing a non-thread-safeLinkedList.Root cause
responsePartsis produced on Netty I/O threads and consumed on test threads.LinkedListcould expose stale/empty reads under race, especially around channel close completion.Change
LinkedList<HttpObject>withConcurrentLinkedQueue<HttpObject>inNettyClient.Effect
Testing Done
Validated by re-running the previously failing frontend integration test path (
multipartPostGetHeadUpdateDeleteUndeleteTest) and the containingFrontendIntegrationTestsuite.