Skip to content

Make sure correct type is used when calling retroarch_get_flags()#18279

Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom
bslenul:rarch-flags-16-to-32
Sep 22, 2025
Merged

Make sure correct type is used when calling retroarch_get_flags()#18279
LibretroAdmin merged 1 commit intolibretro:masterfrom
bslenul:rarch-flags-16-to-32

Conversation

@bslenul
Copy link
Copy Markdown
Contributor

@bslenul bslenul commented Sep 22, 2025

There has been more than 16 flags for a while now, flags was changed to uint32_t a while ago already but retroarch_get_flags() and variables calling it were not updated.

uint32_t flags;

RetroArch/retroarch.h

Lines 91 to 111 in a16d651

enum rarch_state_flags
{
RARCH_FLAGS_HAS_SET_USERNAME = (1 << 0),
RARCH_FLAGS_HAS_SET_VERBOSITY = (1 << 1),
RARCH_FLAGS_HAS_SET_LIBRETRO = (1 << 2),
RARCH_FLAGS_HAS_SET_LIBRETRO_DIRECTORY = (1 << 3),
RARCH_FLAGS_HAS_SET_SAVE_PATH = (1 << 4),
RARCH_FLAGS_HAS_SET_STATE_PATH = (1 << 5),
RARCH_FLAGS_HAS_SET_UPS_PREF = (1 << 6),
RARCH_FLAGS_HAS_SET_BPS_PREF = (1 << 7),
RARCH_FLAGS_HAS_SET_IPS_PREF = (1 << 8),
RARCH_FLAGS_HAS_SET_LOG_TO_FILE = (1 << 9),
RARCH_FLAGS_UPS_PREF = (1 << 10),
RARCH_FLAGS_BPS_PREF = (1 << 11),
RARCH_FLAGS_IPS_PREF = (1 << 12),
RARCH_FLAGS_BLOCK_CONFIG_READ = (1 << 13),
RARCH_FLAGS_CLI_DATABASE_SCAN = (1 << 14),
RARCH_FLAGS_HAS_SET_XDELTA_PREF = (1 << 15),
RARCH_FLAGS_XDELTA_PREF = (1 << 16),
RARCH_FLAGS_HAS_SET_OVERLAY_PRESET = (1 << 17)
};

@LibretroAdmin LibretroAdmin merged commit 6c1b32d into libretro:master Sep 22, 2025
31 checks passed
@bslenul bslenul deleted the rarch-flags-16-to-32 branch September 22, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants