Skip to content

net_http: remove unnecessary receive in connection pool polling #18260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LibretroAdmin merged 1 commit into from
Sep 16, 2025
Merged

net_http: remove unnecessary receive in connection pool polling #18260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions libretro-common/net/net_http.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,23 +703,11 @@ static void net_http_conn_pool_remove_expired(void)
{
if (!entry->in_use && FD_ISSET(entry->fd, &fds))
{
char buf[4096];
bool err = false;
#ifdef HAVE_SSL
if (entry->ssl && entry->ssl_ctx)
ssl_socket_receive_all_nonblocking(entry->ssl_ctx, &err, buf, sizeof(buf));
else
#endif
socket_receive_all_nonblocking(entry->fd, &err, buf, sizeof(buf));

if (!err)
continue;

/* if it's not in use and it's reaadable we assume that means it's closed without checking recv */
if (prev)
prev->next = entry->next;
else
conn_pool = entry->next;
/* if it's not in use and it's reaadable we assume that means it's closed without checking recv */
net_http_conn_pool_free(entry);
entry = prev ? prev->next : conn_pool;
}
Expand Down
Loading