net_http: remove unnecessary receive in connection pool polling#18260
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Sep 16, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously in the
!errcase this would potentially end up in an infinite loop, if the socket was marked readable but *socket_receive_all_nonblocking kept reading data (when it's not supposed to be in_use, meaning not in an active http transaction, which is a bug), or kept not reading data despite being readable and not indicating an error.If we get into this case we can safely assume we don't really understand the state of the socket anymore. It's fine to just close it here, it can just get reopened when someone needs it again.