Deprecate intfstream_open_writable_memory#18216
Merged
LibretroAdmin merged 2 commits intolibretro:masterfrom Aug 30, 2025
Merged
Deprecate intfstream_open_writable_memory#18216LibretroAdmin merged 2 commits intolibretro:masterfrom
intfstream_open_writable_memory#18216LibretroAdmin merged 2 commits intolibretro:masterfrom
Conversation
The function is marked deprecated and rewritten in terms of `intfstream_open_memory`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having both functions is a bit of a footgun since
intfstream_open_memoryignores the given mode and always opens withwritable=false, whileintfstream_open_writable_memoryignores the given mode and always opens withwritable=true.So, I rewrote the
writablevariant in terms of the other one, and deprecated it in the process. Now whether the memory is marked writable depends on the inputmodeforintfstream_open_memory, and thewritablevariant has the same behavior as before.I also replaced the sole use of
intfstream_open_writable_memoryin the retroarch codebase, but I don't know whether any cores or other users of libretro-common used the function so it can't be removed completely.