Deprecate intfstream_open_writable_memory (#18216)

Author: JoeOsborn

libretro-common/formats/png/rpng_encode.c

@@ -410,7 +410,7 @@ uint8_t* rpng_save_image_bgr24_string(const uint8_t *data,
    if (!buf)
       GOTO_END_ERROR();
 
-   intf_s = intfstream_open_writable_memory(buf,
+   intf_s = intfstream_open_memory(buf,
          RETRO_VFS_FILE_ACCESS_WRITE,
          RETRO_VFS_FILE_ACCESS_HINT_NONE,
          _len);

libretro-common/include/streams/interface_stream.h

@@ -121,6 +121,8 @@ intfstream_t *intfstream_open_file(const char *path,
 intfstream_t *intfstream_open_memory(void *data,
       unsigned mode, unsigned hints, uint64_t size);
 
+/* Deprecated.  Has the same effect as `intfstream_open_memory` with
+   a mode including `RETRO_VFS_FILE_ACCESS_WRITE`. */
 intfstream_t *intfstream_open_writable_memory(void *data,
       unsigned mode, unsigned hints, uint64_t size);
 

libretro-common/streams/interface_stream.c

@@ -713,7 +713,7 @@ intfstream_t *intfstream_open_memory(void *data,
    info.type            = INTFSTREAM_MEMORY;
    info.memory.buf.data = (uint8_t*)data;
    info.memory.buf.size = size;
-   info.memory.writable = false;
+   info.memory.writable = (mode & RETRO_VFS_FILE_ACCESS_WRITE) != 0;
 
    if (!(fd = (intfstream_t*)intfstream_init(&info)))
       return NULL;
@@ -729,23 +729,7 @@ intfstream_t *intfstream_open_memory(void *data,
 intfstream_t *intfstream_open_writable_memory(void *data,
       unsigned mode, unsigned hints, uint64_t size)
 {
-   intfstream_info_t info;
-   intfstream_t *fd     = NULL;
-
-   info.type            = INTFSTREAM_MEMORY;
-   info.memory.buf.data = (uint8_t*)data;
-   info.memory.buf.size = size;
-   info.memory.writable = true;
-
-   if (!(fd = (intfstream_t*)intfstream_init(&info)))
-      return NULL;
-
-   if (intfstream_open(fd, NULL, mode, hints))
-      return fd;
-
-   intfstream_close(fd);
-   free(fd);
-   return NULL;
+   return intfstream_open_memory(data, mode | RETRO_VFS_FILE_ACCESS_WRITE, hints, size);
 }
 
 intfstream_t *intfstream_open_chd_track(const char *path,