Skip to content

Refactor GlobalConfigurationCategoryConfigurator to remove raw type cast in describe() #2835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 1 commit into from
Apr 17, 2026
Merged

Refactor GlobalConfigurationCategoryConfigurator to remove raw type cast in describe() #2835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ...a/io/jenkins/plugins/casc/impl/configurators/GlobalConfigurationCategoryConfigurator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,19 +80,24 @@ protected GlobalConfigurationCategory instance(Mapping mapping, ConfigurationCon
return category;
}

@SuppressWarnings("RedundantCast") // TODO remove once we are on JDK 11
@NonNull
@Override
public Set describe() {
return (Set) Jenkins.get().getExtensionList(Descriptor.class).stream()
public Set<Attribute<GlobalConfigurationCategory, ?>> describe() {
return Jenkins.get().getExtensionList(Descriptor.class).stream()
.filter(d -> d.getCategory() == category)
.filter(d -> d.getGlobalConfigPage() != null)
.map(DescriptorConfigurator::new)
.filter(GlobalConfigurationCategoryConfigurator::reportDescriptorWithoutSetters)
.map(c -> new Attribute<GlobalConfigurationCategory, Object>(c.getNames(), c.getTarget()).setter(NOP))
.map(c -> new Attribute<GlobalConfigurationCategory, Object>(c.getNames(), c.getTarget())
.setter(typedNop()))
.collect(Collectors.toSet());
}

@SuppressWarnings("unchecked")
private static <T, V> Attribute.Setter<T, V> typedNop() {
return (Attribute.Setter<T, V>) NOP;
}

public static boolean reportDescriptorWithoutSetters(Configurator c) {
if (c.describe().isEmpty()) {
LOGGER.fine(
Expand Down
Loading