Refactor GlobalConfigurationCategoryConfigurator to remove raw type cast in describe()#2835
Merged
timja merged 1 commit intojenkinsci:masterfrom Apr 17, 2026
Merged
Conversation
…ast in describe()
timja
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor GlobalConfigurationCategoryConfigurator.describe() to eliminate raw types and remove the redundant cast required for pre-JDK 11 compatibility by introducing generics (Set<Attribute<GlobalConfigurationCategory, ?>>). Replace the inline unchecked cast of NOP with a helper method (typedNop()) that encapsulates the suppression, keeps the code clean, and maintains existing behavior.
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.