Skip to content

Refactor GlobalConfigurationCategoryConfigurator to remove raw type cast in describe()#2835

Merged
timja merged 1 commit intojenkinsci:masterfrom
somiljain2006:compatibility-fix
Apr 17, 2026
Merged

Refactor GlobalConfigurationCategoryConfigurator to remove raw type cast in describe()#2835
timja merged 1 commit intojenkinsci:masterfrom
somiljain2006:compatibility-fix

Conversation

@somiljain2006
Copy link
Copy Markdown
Contributor

@somiljain2006 somiljain2006 commented Apr 17, 2026

Refactor GlobalConfigurationCategoryConfigurator.describe() to eliminate raw types and remove the redundant cast required for pre-JDK 11 compatibility by introducing generics (Set<Attribute<GlobalConfigurationCategory, ?>>). Replace the inline unchecked cast of NOP with a helper method (typedNop()) that encapsulates the suppression, keeps the code clean, and maintains existing behavior.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test case? That demonstrates a feature that works or fixes the issue.

@somiljain2006 somiljain2006 requested a review from a team as a code owner April 17, 2026 17:24
@timja timja added the chore a PR that adds to maintenance - used by Release Drafter label Apr 17, 2026
@timja timja merged commit fb98ed9 into jenkinsci:master Apr 17, 2026
17 checks passed
@somiljain2006 somiljain2006 deleted the compatibility-fix branch April 18, 2026 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a PR that adds to maintenance - used by Release Drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants