Skip to content

fix(custom-property): return error for empty property_value instead of panicking #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

fix(custom-property): return error for empty property_value instead of panicking #3366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions github/resource_github_repository_custom_property.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ func resourceGithubRepositoryCustomPropertyCreate(d *schema.ResourceData, meta a
// The propertyValue can either be a list of strings or a string
switch propertyType {
case github.PropertyValueTypeString, github.PropertyValueTypeSingleSelect, github.PropertyValueTypeURL, github.PropertyValueTypeTrueFalse:
if len(propertyValue) == 0 {
return fmt.Errorf("property_value must contain at least one element for property_type %q", propertyType)
}
customProperty.Value = propertyValue[0]
case github.PropertyValueTypeMultiSelect:
customProperty.Value = propertyValue
Expand Down