fix(custom-property): return error for empty property_value instead of panicking#3366
Open
SAY-5 wants to merge 1 commit intointegrations:mainfrom
Open
fix(custom-property): return error for empty property_value instead of panicking#3366SAY-5 wants to merge 1 commit intointegrations:mainfrom
SAY-5 wants to merge 1 commit intointegrations:mainfrom
Conversation
…f panicking
resource_github_repository_custom_property.go:72 unconditionally
dereferenced propertyValue[0] for scalar property_type values
(string, single_select, url, true_false). Terraform configurations
that supplied property_value as an empty list — or where a computed
value resolved to empty at apply time — crashed the provider with:
panic: runtime error: index out of range [0] with length 0
resourceGithubRepositoryCustomPropertyCreate ... +0x698
OpenTofu / Terraform recovers from this as a plugin crash, leaves
dangling resource state, and reports it as an internal provider
error rather than a user-facing configuration error.
Guard the index with an explicit length check that returns a clear
Terraform error naming the offending property_type. Multi_select is
unaffected — an empty slice there is intentionally allowed.
Refs integrations/terraform-provider-github issue 3358.
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3358.
Problem
resourceGithubRepositoryCustomPropertyCreateunconditionally accessedpropertyValue[0]for scalarproperty_typevalues (string,single_select,url,true_false). Terraform / OpenTofu plans that resolveproperty_valueto an empty list — either explicitly or via a computed source — crashed the provider with:OpenTofu surfaces this as a plugin crash rather than a configuration error, leaving resource state dangling.
Fix
Guard the index with an explicit length check that returns a clear Terraform error naming the offending
property_type.multi_selectis unaffected — an empty slice there is intentionally allowed.Test
go build ./...clean. Behavior on non-empty values is unchanged; the previous panic path now returns a descriptive error.