Extract rule: template-deprecated-inline-view-helper#2450
Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom Mar 13, 2026
Conversation
NullVoxPopuli
force-pushed
the
nvp/template-lint-extract-rule-template-deprecated-inline-view-helper
branch
3 times, most recently
from
4991498 to
836c344
Compare
kategengler
reviewed
Mar 7, 2026
| @@ -0,0 +1,35 @@ | |||
| # ember/template-deprecated-inline-view-helper | |||
|
|
|||
| > **HBS Only**: This rule applies to classic `.hbs` template files only (loose mode). It is not relevant for `gjs`/`gts` files (strict mode), where these patterns cannot occur. | |||
Member
There was a problem hiding this comment.
This was deprecated in 1.x. I don't believe any 1.x project is going to be managing to use this plugin (it pre-dated npm), so should we bother porting this rule?
Contributor
Author
There was a problem hiding this comment.
It's easier for me to justify a migration path from ember-template-lint if an initial recommended-hbs is the same as in ember-template-lint
Member
There was a problem hiding this comment.
I guess? I doubt any 1.x project was using that either tbh
Contributor
There was a problem hiding this comment.
i agree it can be skipped.
if not:
- No
isLocalcheck:{{#each items as |view|}}{{view.name}}{{/each}}would be falsely flagged. - Missing dedup guard: No
_processedByInlineViewHelperequivalent — same node could be reported twice (once from element visitor, once from mustache visitor). - No autofix: Original provides fix suggestions (removing
view.prefix).
NullVoxPopuli
force-pushed
the
nvp/template-lint-extract-rule-template-deprecated-inline-view-helper
branch
from
836c344 to
09ba09c
Compare
NullVoxPopuli
force-pushed
the
nvp/template-lint-extract-rule-template-deprecated-inline-view-helper
branch
from
09ba09c to
438984d
Compare
NullVoxPopuli
deleted the
nvp/template-lint-extract-rule-template-deprecated-inline-view-helper
branch
NullVoxPopuli
added a commit
that referenced
this pull request
Mar 14, 2026
Post-merge review of #2450 (`template-deprecated-inline-view-helper`)
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #2371.