Merge pull request #2525 from johanrd/review/2450

Post-merge review of #2450 (`template-deprecated-inline-view-helper`)

Author: NullVoxPopuli

lib/rules/template-deprecated-inline-view-helper.js

@@ -60,7 +60,22 @@ module.exports = {
 
     function checkHashForViewPaths(node) {
       if (node.hash && node.hash.pairs) {
+        // Skip {{yield}} invocations — yield hash pairs are not view references
+        const isYield =
+          node.path &&
+          node.path.type === 'GlimmerPathExpression' &&
+          node.path.original === 'yield' &&
+          node.path.head?.type !== 'ThisHead' &&
+          node.path.head?.type !== 'AtHead';
+        if (isYield) {
+          return false;
+        }
+
         for (const pair of node.hash.pairs) {
+          // Skip hash pairs with key "to" (e.g., {{yield to="inverse"}})
+          if (pair.key === 'to') {
+            continue;
+          }
           if (isViewPath(pair.value)) {
             const strippedValue = pair.value.original.replace('view.', '');
             context.report({
@@ -135,6 +150,26 @@ module.exports = {
       },
 
       GlimmerElementNode(node) {
+        // Check element attributes for view.* references (e.g., <div class={{view.something}}>)
+        if (node.attributes) {
+          for (const attr of node.attributes) {
+            if (
+              attr.value &&
+              attr.value.type === 'GlimmerMustacheStatement' &&
+              isViewPath(attr.value.path)
+            ) {
+              const strippedValue = attr.value.path.original.replace('view.', '');
+              context.report({
+                node: attr.value,
+                messageId: 'deprecated',
+                fix(fixer) {
+                  return fixer.replaceText(attr.value.path, strippedValue);
+                },
+              });
+            }
+          }
+        }
+
         if (node.blockParams && node.blockParams.length > 0) {
           pushLocals(node.blockParams);
         }
@@ -146,6 +181,11 @@ module.exports = {
       },
 
       GlimmerMustacheStatement(node) {
+        // Skip mustache statements that are element attribute values;
+        // those are handled by the GlimmerElementNode visitor instead.
+        if (node.parent && node.parent.type === 'GlimmerAttrNode') {
+          return;
+        }
         checkForView(node);
       },
     };

tests/lib/rules/template-deprecated-inline-view-helper.js

@@ -26,6 +26,10 @@ ruleTester.run('template-deprecated-inline-view-helper', rule, {
     '<template>{{#let this.prop as |view|}} {{view}} {{/let}}</template>',
     // isLocal: view is a block param, view.name should not be flagged
     '<template>{{#each items as |view|}} {{view.name}} {{/each}}</template>',
+    // yield with view hash pair should not be flagged
+    '<template>{{yield hash=view.foo}}</template>',
+    // hash pair with key "to" should not be flagged
+    '<template>{{some-component to=view.foo}}</template>',
   ],
   invalid: [
     {
@@ -53,6 +57,11 @@ ruleTester.run('template-deprecated-inline-view-helper', rule, {
       output: '<template>{{foo-bar bab=good baz=qux.qaz boo=okay}}</template>',
       errors: [{ messageId: 'deprecated' }],
     },
+    {
+      code: '<template><div class={{view.something}}></div></template>',
+      output: '<template><div class={{something}}></div></template>',
+      errors: [{ messageId: 'deprecated' }],
+    },
     {
       code: '<template><div class="whatever-class" data-foo={{view.hallo}} sure=thing></div></template>',
       output:
@@ -93,6 +102,10 @@ hbsRuleTester.run('template-deprecated-inline-view-helper', rule, {
     '{{#let this.prop as |view|}} {{view}} {{/let}}',
     // isLocal: view is a block param, view.name should not be flagged
     '{{#each items as |view|}} {{view.name}} {{/each}}',
+    // yield with view hash pair should not be flagged
+    '{{yield hash=view.foo}}',
+    // hash pair with key "to" should not be flagged
+    '{{some-component to=view.foo}}',
   ],
   invalid: [
     {
@@ -135,6 +148,16 @@ hbsRuleTester.run('template-deprecated-inline-view-helper', rule, {
         },
       ],
     },
+    {
+      code: '<div class={{view.something}}></div>',
+      output: '<div class={{something}}></div>',
+      errors: [
+        {
+          message:
+            'The inline form of `view` is deprecated. Please use `Ember.Component` instead. See http://emberjs.com/deprecations/v1.x/#toc_ember-view',
+        },
+      ],
+    },
     {
       code: '<div class="whatever-class" data-foo={{view.hallo}} sure=thing></div>',
       output: '<div class="whatever-class" data-foo={{hallo}} sure=thing></div>',