We have prettier (and thus editors detect and run it), but what we check in CI is different#2368
Merged
NullVoxPopuli merged 7 commits intomasterfrom Jan 29, 2026
Merged
Conversation
…t, and thus already running in editors)
…hat revealed prettier behavior via eslint to be completely out of sync with the on-disk prettier config
NullVoxPopuli
changed the title
wagenet
approved these changes
Jan 29, 2026
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we were using eslint-plugin-prettier with a different config than the prettierrc -- this resulted in a mismatch between editor behavior and what CI was checking.