Merge pull request #2368 from ember-cli/nvp/internal-enforce-prettier

We have prettier (and thus editors detect and run it), but what we check in CI is different

Author: NullVoxPopuli

.prettierignore

@@ -1 +1,7 @@
+node_modules/
+dist/
 lib/recommended-rules.js
+CHANGELOG.md
+README.md
+pnpm-lock.yaml
+.github/*

docs/rules/_TEMPLATE_.md

@@ -42,8 +42,10 @@ TODO: suggest any fast/automated techniques for fixing violations in a large cod
 ## Configuration
 
 <!-- begin auto-generated rule options list -->
+
 TODO: exclude this section if the rule has no extra configuration.
 TODO: ensure `meta.schema` contains descriptions, constraints, defaults, etc for all options.
+
 <!-- end auto-generated rule options list -->
 
 ## Related Rules

docs/rules/alias-model-in-controller.md

@@ -15,7 +15,7 @@ We can do this in two ways:
   import { alias } from '@ember/object/computed';
 
   export default Controller.extend({
-    nail: alias('model')
+    nail: alias('model'),
   });
   ```
 
@@ -27,7 +27,7 @@ We can do this in two ways:
   export default Route.extend({
     setupController(controller, model) {
       controller.set('nail', model);
-    }
+    },
   });
   ```
 
@@ -39,12 +39,12 @@ import { reads } from '@ember/object/computed';
 
 export default Controller.extend({
   people: reads('model.people'),
-  pets: reads('model.pets')
+  pets: reads('model.pets'),
 });
 ```
 
 ## Help Wanted
 
-| Issue | Link |
-| :-- | :-- |
+| Issue                                      | Link                                                                |
+| :----------------------------------------- | :------------------------------------------------------------------ |
 | ❌ Missing native JavaScript class support | [#560](https://github.com/ember-cli/eslint-plugin-ember/issues/560) |

docs/rules/avoid-leaking-state-in-ember-objects.md

@@ -17,16 +17,16 @@ export default Foo.extend({
   actions: {
     addItem(item) {
       this.items.pushObject(item);
-    }
-  }
+    },
+  },
 });
 ```
 
 ```js
 import Mixin from '@ember/object/mixin';
 
 export default Mixin.create({
-  items: []
+  items: [],
 });
 ```
 
@@ -43,8 +43,8 @@ export default Foo.extend({
   actions: {
     addItem(item) {
       this.items.pushObject(item);
-    }
-  }
+    },
+  },
 });
 ```
 
@@ -71,9 +71,9 @@ module.exports = {
   rules: {
     'ember/avoid-leaking-state-in-ember-objects': [
       'error',
-      ['array', 'of', 'ignored', 'properties']
-    ]
-  }
+      ['array', 'of', 'ignored', 'properties'],
+    ],
+  },
 };
 ```
 

docs/rules/avoid-using-needs-in-controllers.md

@@ -13,7 +13,7 @@ Examples of **incorrect** code for this rule:
 ```js
 export default Controller.extend({
   needs: ['comments'],
-  newComments: alias('controllers.comments.newest')
+  newComments: alias('controllers.comments.newest'),
 });
 ```
 
@@ -24,12 +24,12 @@ import Controller, { inject as controller } from '@ember/controller';
 
 export default Component.extend({
   comments: controller(),
-  newComments: alias('comments.newest')
+  newComments: alias('comments.newest'),
 });
 ```
 
 ## Help Wanted
 
-| Issue | Link |
-| :-- | :-- |
+| Issue                                      | Link                                                                |
+| :----------------------------------------- | :------------------------------------------------------------------ |
 | ❌ Missing native JavaScript class support | [#560](https://github.com/ember-cli/eslint-plugin-ember/issues/560) |

docs/rules/closure-actions.md

@@ -13,8 +13,8 @@ export default Controller.extend({
   actions: {
     detonate() {
       alert('Kabooom');
-    }
-  }
+    },
+  },
 });
 ```
 
@@ -30,8 +30,8 @@ export default Component.extend({
   actions: {
     pushLever() {
       this.sendAction('detonate');
-    }
-  }
+    },
+  },
 });
 ```
 
@@ -47,8 +47,8 @@ export default Component.extend({
   actions: {
     pushLever() {
       this.boom();
-    }
-  }
+    },
+  },
 });
 ```
 

docs/rules/computed-property-getters.md

@@ -13,9 +13,9 @@ This rule takes a single string option.
 
 String option:
 
-- `"always-with-setter"` (default) getters are *required* when computed property has a setter
-- `"always"` getters are *required* in computed properties
-- `"never"`  getters are *never allowed* in computed properties
+- `"always-with-setter"` (default) getters are _required_ when computed property has a setter
+- `"always"` getters are _required_ in computed properties
+- `"never"` getters are _never allowed_ in computed properties
 
 ## Examples
 
@@ -29,15 +29,15 @@ EmberObject.extend({
   fullName: computed('firstName', 'lastName', {
     get() {
       // ...
-    }
-  })
+    },
+  }),
 });
 
 // GOOD
 EmberObject.extend({
   fullName: computed('firstName', 'lastName', function () {
     // ...
-  })
+  }),
 });
 
 // GOOD
@@ -48,8 +48,8 @@ EmberObject.extend({
     },
     get() {
       // ...
-    }
-  })
+    },
+  }),
 });
 ```
 
@@ -63,15 +63,15 @@ EmberObject.extend({
   fullName: computed('firstName', 'lastName', {
     get() {
       // ...
-    }
-  })
+    },
+  }),
 });
 
 // BAD
 EmberObject.extend({
   fullName: computed('firstName', 'lastName', function () {
     // ...
-  })
+  }),
 });
 ```
 
@@ -84,16 +84,16 @@ import EmberObject, { computed } from '@ember/object';
 EmberObject.extend({
   fullName: computed('firstName', 'lastName', function () {
     // ...
-  })
+  }),
 });
 
 // BAD
 EmberObject.extend({
   fullName: computed('firstName', 'lastName', {
     get() {
       // ...
-    }
-  })
+    },
+  }),
 });
 
 // BAD
@@ -104,13 +104,13 @@ EmberObject.extend({
     },
     set() {
       // ...
-    }
-  })
+    },
+  }),
 });
 ```
 
 ## Help Wanted
 
-| Issue | Link |
-| :-- | :-- |
+| Issue                                      | Link                                                                |
+| :----------------------------------------- | :------------------------------------------------------------------ |
 | ❌ Missing native JavaScript class support | [#560](https://github.com/ember-cli/eslint-plugin-ember/issues/560) |

docs/rules/named-functions-in-promises.md

@@ -40,7 +40,7 @@ export default Component.extend({
         .then(() => this._reloadUser())
         .then(() => this._notifyAboutSuccess())
         .catch(() => this._notifyAboutFailure());
-    }
+    },
   },
   _reloadUser(user) {
     return user.reload();
@@ -50,7 +50,7 @@ export default Component.extend({
   },
   _notifyAboutFailure() {
     // ...
-  }
+  },
 });
 ```
 

docs/rules/no-actions-hash.md

@@ -22,8 +22,8 @@ import Component from '@ember/component';
 
 export default Component.extend({
   actions: {
-    foo() {}
-  }
+    foo() {},
+  },
 });
 ```
 
@@ -33,7 +33,7 @@ import Component from '@ember/component';
 
 export class MyComponent extends Component {
   actions = {
-    foo() {}
+    foo() {},
   };
 }
 ```
@@ -46,7 +46,7 @@ import Component from '@ember/component';
 import { action } from '@ember/object';
 
 export default Component.extend({
-  foo: action(function () {})
+  foo: action(function () {}),
 });
 ```
 

docs/rules/no-arrow-function-computed-properties.md

@@ -20,7 +20,7 @@ import EmberObject, { computed } from '@ember/object';
 const Person = EmberObject.extend({
   fullName: computed('firstName', 'lastName', () => {
     return `${this.firstName} ${this.lastName}`;
-  })
+  }),
 });
 ```
 
@@ -32,7 +32,7 @@ import EmberObject, { computed } from '@ember/object';
 const Person = EmberObject.extend({
   fullName: computed('firstName', 'lastName', function () {
     return `${this.firstName} ${this.lastName}`;
-  })
+  }),
 });
 ```