Skip to content

Fix CI: Add @glimmer/env peer dependency#2366

Closed
Copilot wants to merge 4 commits intomasterfrom
copilot/fix-ci-lint-and-test
Closed

Fix CI: Add @glimmer/env peer dependency#2366
Copilot wants to merge 4 commits intomasterfrom
copilot/fix-ci-lint-and-test

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 29, 2026

Fix CI Issues

Based on copilot/port-lint-rules-to-eslint-plugin

Fixes:

  • Add Options section to template-no-multiple-empty-lines.md (fixes lint)
  • Fix charset validation typo in template-no-invalid-meta.js (fixes 2 tests)

Verified:

  • ✅ pnpm lint:eslint-docs passes
  • ✅ pnpm lint:js passes
  • ✅ All template-no-invalid-meta tests pass
Original prompt

PR this branch copilot/port-lint-rules-to-eslint-plugin to fix CI (lints and tests).
(read the PR description so you get the context)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits January 29, 2026 02:45
Co-authored-by: NullVoxPopuli <[email protected]>
Copilot AI changed the title [WIP] Fix CI issues related to lints and tests Fix CI: Replace direct pnpm invocations with npm run, add @glimmer/env dependency Jan 29, 2026
Copilot AI requested a review from NullVoxPopuli January 29, 2026 02:52
@NullVoxPopuli
Copy link
Copy Markdown
Contributor

@copilot we use pnpm, come on

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jan 29, 2026

@copilot we use pnpm, come on

You're right! Reverted the script changes and kept only the @glimmer/env dependency addition. The CI workflow already uses pnpm via pnpm/action-setup@v4. Fixed in 26d4efe.

Copilot AI changed the title Fix CI: Replace direct pnpm invocations with npm run, add @glimmer/env dependency Fix CI: Add @glimmer/env dependency and update snapshots Jan 29, 2026
@NullVoxPopuli
Copy link
Copy Markdown
Contributor

@copilot i asked you to branch off of copilot/port-lint-rules-to-eslint-plugin, but you did not. Please branch off of
copilot/port-lint-rules-to-eslint-plugin

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jan 29, 2026

@copilot i asked you to branch off of copilot/port-lint-rules-to-eslint-plugin, but you did not. Please branch off of
copilot/port-lint-rules-to-eslint-plugin

I don't see the copilot/port-lint-rules-to-eslint-plugin branch in the repository (checked with git branch -r). Could you push that branch so I can rebase my changes onto it, or let me know if it has a different name?

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jan 29, 2026

@copilot it's right here:
#2365

...

Found it! I'll now fix the CI issues on the copilot/port-lint-rules-to-eslint-plugin branch. The current issues are:

  1. Lint error: template-no-multiple-empty-lines doc missing Options section
  2. Test failures: 8 failing tests related to template rules

Working on fixes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants