Conversation
|
How can I help in any way as I have wanted to have this for some of my internal/external addons? |
|
Are you available for the tooling team meeting on Tuesday? I hope to have this spike fleshed out by then, so we can discuss alternatives and what needs we all have |
mansona
left a comment
mansona
left a comment
There was a problem hiding this comment.
I know this is draft but I had a few things that I wanted to comment on early ❤️
| './router': Router, | ||
| './services/page-title': PageTitleService, | ||
| // add any custom services here | ||
| // import.meta.glob('./services/*', { eager: true }), |
There was a problem hiding this comment.
can we just leave imports here so that if people add things in the folder structure they start working automagically?
There was a problem hiding this comment.
also it looks like we forgot the import for the application template 🤔 maybe we should add a test that generates an addon and navigates to the demo app to see that it renders properly?
There was a problem hiding this comment.
I can't have tests because someone said to not have tests :p
There was a problem hiding this comment.
we are not in the same group of people as the ones consuming this blueprint. We are able to have a scenario that generates an addon and then uses puppeteer to ensure that the app renders correctly. We can even have a fixture that adds a bunch of things to the demo app to make sure it works.
|
@aklkv you don't need this PR to start using the ideas represented in here. This PR is for making the default experience better for everyone |
Well I already do, I just want to make sure that this is official direction |
NullVoxPopuli
force-pushed
the
docs-app
branch
from
7006654 to
7c96002
Compare
mansona
left a comment
mansona
left a comment
There was a problem hiding this comment.
I'm sure we can probably improve some of the comments but this is ready to merge and we can iterate from main 👍
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
|
|
||
| <link rel="stylesheet" href="./docs-app/styles.css" /> |
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>Docs App</title> |
4 participants
Requires: #73