Skip to content

Change import statement to use named import for App#99

Merged
NullVoxPopuli merged 1 commit intomainfrom
NullVoxPopuli-patch-2
Oct 19, 2025
Merged

Change import statement to use named import for App#99
NullVoxPopuli merged 1 commit intomainfrom
NullVoxPopuli-patch-2

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli commented Oct 19, 2025

This import must match this export:

export class App extends EmberApp {

Issue introduced in
#89

@evoactivity mentioned a thing that is probably worth mentioning reasoning behind:

A named import diverges from the main app Blueprint:

but only because the main app blueprint is beholden to previous blueprints.
I argue that:

  1. an import in your app from your app should be a named import. (Otherwise why name anything at all? Named exports also help a toooon with import suggestions)
  2. Leave export default for 'the framework'.

This is also base common expectations for the ecosystem for like.. 10 years, so there is a lot of precedent.

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Oct 19, 2025
@NullVoxPopuli NullVoxPopuli merged commit 2839f5f into main Oct 19, 2025
15 checks passed
@NullVoxPopuli NullVoxPopuli deleted the NullVoxPopuli-patch-2 branch October 19, 2025 22:46
@NullVoxPopuli
Copy link
Copy Markdown
Contributor Author

Merged because #89 was released in 0.14 earlier today

@github-actions github-actions Bot mentioned this pull request Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant