Change import statement to use named import for App#99
Merged
NullVoxPopuli merged 1 commit intomainfrom Oct 19, 2025
Merged
Conversation
Contributor
Author
|
Merged because #89 was released in 0.14 earlier today |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This import must match this export:
ember-addon-blueprint/files/demo-app/app.gts
Line 10 in 2a95a64
Issue introduced in
#89
@evoactivity mentioned a thing that is probably worth mentioning reasoning behind:
A named import diverges from the main app Blueprint:
but only because the main app blueprint is beholden to previous blueprints.
I argue that:
This is also base common expectations for the ecosystem for like.. 10 years, so there is a lot of precedent.