test: container wrapping binary built with optional deps

[jbedard]

Changes are visible to end-users: no

Test plan

• New test cases added

[aspect-workflows]

Bazel 7 (Test)

⚠️ Buildkite build #12545 is currently failing.

Failing tests (5)

//js/private/test/image:assert_custom_layers_nomatch_test_package_store_3p_test [k8-fastbuild] 🔗
//js/private/test/image:assert_custom_owner_test_package_store_3p_test [k8-fastbuild]          🔗
//js/private/test/image:assert_default_test_package_store_3p_test [k8-fastbuild]               🔗
//js/private/test/image:assert_regex_edge_cases_test_package_store_3p_test [k8-fastbuild]      🔗
//js/private/test/image:checksum_test_test_test [k8-fastbuild]                                 🔗

💡 To reproduce the test failures, run

bazel test //js/private/test/image:assert_custom_owner_test_package_store_3p_test //js/private/test/image:assert_default_test_package_store_3p_test //js/private/test/image:assert_custom_layers_nomatch_test_package_store_3p_test //js/private/test/image:assert_regex_edge_cases_test_package_store_3p_test //js/private/test/image:checksum_test_test_test

---

Bazel 8 (Test)

2 test targets passed

Targets

//npm/private/test:node_modules_test [k8-fastbuild] 27ms
//npm/private/test:pkg_versions_test [k8-fastbuild] 58ms

Total test execution time was 85ms. 208 tests (99.0%) were fully cached saving 26s.

---

Bazel 9 (Test)

Buildkite build #12545 is running...

---

Bazel 7 (Test)

e2e/bzlmod

All tests were cache hits

7 tests (100.0%) were fully cached saving 664ms.

---

Bazel 8 (Test)

e2e/bzlmod

All tests were cache hits

7 tests (100.0%) were fully cached saving 642ms.

---

Bazel 9 (Test)

e2e/bzlmod

All tests were cache hits

7 tests (100.0%) were fully cached saving 596ms.

---

Bazel 7 (Test)

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

---

Bazel 8 (Test)

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.

---

Bazel 9 (Test)

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

---

Bazel 7 (Test)

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 112ms.

---

Bazel 8 (Test)

e2e/gyp_no_install_script

All tests were cache hits

1 test (100.0%) was fully cached saving 50ms.

---

Bazel 9 (Test)

e2e/gyp_no_install_script

All tests were cache hits

1 test (100.0%) was fully cached saving 46ms.

---

Bazel 7 (Test)

e2e/js_binary_workspace

All tests were cache hits

1 test (100.0%) was fully cached saving 44ms.

---

Bazel 8 (Test)

e2e/js_binary_workspace

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

---

Bazel 9 (Test)

e2e/js_binary_workspace

All tests were cache hits

1 test (100.0%) was fully cached saving 35ms.

---

Bazel 7 (Test)

e2e/js_image_oci

Buildkite build #12545 is running...

---

Bazel 7 (Test)

e2e/nextjs

All tests were cache hits

3 tests (100.0%) were fully cached saving 165ms.

---

Bazel 8 (Test)

e2e/nextjs

All tests were cache hits

3 tests (100.0%) were fully cached saving 94ms.

---

Bazel 9 (Test)

e2e/nextjs

All tests were cache hits

3 tests (100.0%) were fully cached saving 112ms.

---

Bazel 7 (Test)

e2e/npm_link_package

All tests were cache hits

4 tests (100.0%) were fully cached saving 414ms.

---

Bazel 8 (Test)

e2e/npm_link_package

All tests were cache hits

4 tests (100.0%) were fully cached saving 363ms.

---

Bazel 9 (Test)

e2e/npm_link_package

All tests were cache hits

4 tests (100.0%) were fully cached saving 415ms.

---

Bazel 7 (Test)

e2e/npm_link_package-rerooted

All tests were cache hits

2 tests (100.0%) were fully cached saving 207ms.

---

Bazel 8 (Test)

e2e/npm_link_package-rerooted

All tests were cache hits

2 tests (100.0%) were fully cached saving 139ms.

---

Bazel 9 (Test)

e2e/npm_link_package-rerooted

All tests were cache hits

2 tests (100.0%) were fully cached saving 186ms.

---

Bazel 7 (Test)

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 383ms.

---

Bazel 8 (Test)

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 287ms.

---

Bazel 9 (Test)

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 289ms.

---

Bazel 7 (Test)

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

3 tests (100.0%) were fully cached saving 268ms.

---

Bazel 8 (Test)

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

1 test (100.0%) was fully cached saving 62ms.

---

Bazel 9 (Test)

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.

---

Bazel 7 (Test)

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 132ms.

---

Bazel 8 (Test)

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 114ms.

---

Bazel 9 (Test)

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 105ms.

---

Bazel 7 (Test)

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 33ms.

---

Bazel 8 (Test)

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 21ms.

---

Bazel 9 (Test)

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 86ms.

---

Bazel 7 (Test)

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 106ms.

---

Bazel 8 (Test)

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 54ms.

---

Bazel 9 (Test)

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 113ms.

---

Bazel 7 (Test)

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.

---

Bazel 8 (Test)

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

---

Bazel 9 (Test)

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 38ms.

---

Bazel 7 (Test)

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 321ms.

---

Bazel 8 (Test)

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 249ms.

---

Bazel 9 (Test)

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 320ms.

---

Bazel 7 (Test)

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 50ms.

---

Bazel 8 (Test)

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 67ms.

---

Bazel 9 (Test)

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 50ms.

---

Bazel 7 (Test)

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 25ms.

---

Bazel 8 (Test)

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 62ms.

---

Bazel 9 (Test)

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.

---

Bazel 7 (Test)

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 25ms.

---

Bazel 8 (Test)

e2e/npm_translate_yarn_lock

Buildkite build #12545 is running...

---

Bazel 9 (Test)

e2e/npm_translate_yarn_lock

Buildkite build #12545 is running...

---

Bazel 7 (Test)

e2e/output_paths

Buildkite build #12545 is running...

---

Bazel 8 (Test)

e2e/output_paths

Buildkite build #12545 is running...

---

Bazel 9 (Test)

e2e/output_paths

All tests were cache hits

2 tests (100.0%) were fully cached saving 171ms.

---

Bazel 7 (Test)

e2e/patch_from_repo

All tests were cache hits

1 test (100.0%) was fully cached saving 25ms.

---

Bazel 7 (Test)

e2e/pnpm_lockfiles

Buildkite build #12545 is running...

---

Bazel 8 (Test)

e2e/pnpm_lockfiles

Buildkite build #12545 is running...

---

Bazel 9 (Test)

e2e/pnpm_lockfiles

All tests were cache hits

17 tests (100.0%) were fully cached saving 1s.

---

Bazel 7 (Test)

e2e/pnpm_repo_install

All tests were cache hits

1 test (100.0%) was fully cached saving 746ms.

---

Bazel 8 (Test)

e2e/pnpm_repo_install

All tests were cache hits

1 test (100.0%) was fully cached saving 772ms.

---

Bazel 9 (Test)

e2e/pnpm_repo_install

All tests were cache hits

1 test (100.0%) was fully cached saving 738ms.

---

Bazel 7 (Test)

e2e/pnpm_version

Buildkite build #12545 is running...

---

Bazel 8 (Test)

e2e/pnpm_version

All tests were cache hits

1 test (100.0%) was fully cached saving 44ms.

---

Bazel 9 (Test)

e2e/pnpm_version

All tests were cache hits

1 test (100.0%) was fully cached saving 42ms.

---

Bazel 7 (Test)

e2e/pnpm_workspace

Buildkite build #12545 is running...

---

Bazel 8 (Test)

e2e/pnpm_workspace

Buildkite build #12545 is running...

---

Bazel 9 (Test)

e2e/pnpm_workspace

Buildkite build #12545 is running...

---

Bazel 7 (Test)

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 212ms.

---

Bazel 8 (Test)

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 278ms.

---

Bazel 9 (Test)

e2e/pnpm_workspace_deps

Buildkite build #12545 is running...

---

Bazel 7 (Test)

e2e/pnpm_workspace_rerooted

All tests were cache hits

15 tests (100.0%) were fully cached saving 2s.

---

Bazel 8 (Test)

e2e/pnpm_workspace_rerooted

Buildkite build #12545 is running...

---

Bazel 9 (Test)

e2e/pnpm_workspace_rerooted

All tests were cache hits

14 tests (100.0%) were fully cached saving 2s.

---

Bazel 7 (Test)

e2e/protobuf-es

Buildkite build #12545 is running...

---

Bazel 8 (Test)

e2e/protobuf-es

Buildkite build #12545 is running...

---

Bazel 9 (Test)

e2e/protobuf-es

All tests were cache hits

1 test (100.0%) was fully cached saving 147ms.

---

Bazel 7 (Test)

e2e/protobuf-google

All tests were cache hits

1 test (100.0%) was fully cached saving 97ms.

---

Bazel 8 (Test)

e2e/protobuf-google

Buildkite build #12545 is running...

---

Bazel 9 (Test)

e2e/protobuf-google

Buildkite build #12545 is running...

---

Bazel 7 (Test)

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 222ms.

---

Bazel 8 (Test)

e2e/repo_mapping

Buildkite build #12545 is running...

---

Bazel 9 (Test)

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 308ms.

---

Bazel 7 (Test)

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 61ms.

---

Bazel 8 (Test)

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 57ms.

---

Bazel 9 (Test)

e2e/vendored_node

Buildkite build #12545 is running...

---

Bazel 7 (Test)

e2e/vendored_tarfile

All tests were cache hits

1 test (100.0%) was fully cached saving 25ms.

---

Bazel 8 (Test)

e2e/vendored_tarfile

All tests were cache hits

1 test (100.0%) was fully cached saving 62ms.

---

Bazel 9 (Test)

e2e/vendored_tarfile

Buildkite build #12545 is running...

---

Bazel 7 (Test)

e2e/verify_patches

Buildkite build #12545 is running...

---

Bazel 8 (Test)

e2e/verify_patches

All tests were cache hits

2 tests (100.0%) were fully cached saving 120ms.

---

Bazel 9 (Test)

e2e/verify_patches

Waiting for runner...

---

Bazel 7 (Test)

examples

All tests were cache hits

83 tests (100.0%) were fully cached saving 11s.

---

Bazel 8 (Test)

examples

All tests were cache hits

81 tests (100.0%) were fully cached saving 11s.

---

Bazel 9 (Test)

examples

All tests were cache hits

81 tests (100.0%) were fully cached saving 12s.

---

Buildifier      Format

[jbedard]

Notice this has downloaded-@esbuild-darwin-arm64-esbuild in it which I think is wrong and potentially a bug. I'm not sure who's bug that would be though...