test: container wrapping binary built with optional deps

Author: jbedard

.aspect/rules/external_repository_action_cache/npm_translate_lock_LTE4Nzc1MDcwNjU=

@@ -32,11 +32,11 @@ js/private/worker/src/package.json=1787033725
 npm/private/lifecycle/package.json=804720835
 npm/private/test/npm_package/package.json=-1991705133
 npm/private/test/npm_package_publish/package.json=1501316979
-npm/private/test/package.json=550137760
+npm/private/test/package.json=32523622
 npm/private/test/subs/package.json=-897547334
 npm/private/test/vendored/is-odd/package.json=1041695223
 npm/private/test/vendored/lodash-4.17.21.tgz=-1206623349
 npm/private/test/vendored/semver-max/package.json=578664053
 package.json=1856600154
-pnpm-lock.yaml=-1083936682
+pnpm-lock.yaml=-299891068
 pnpm-workspace.yaml=2041973211

MODULE.bazel

@@ -243,10 +243,6 @@ npm.npm_translate_lock(
             "no-sandbox",
             "requires-network",
         ],
-        "esbuild": [
-            "no-sandbox",
-            "requires-network",
-        ],
         "segfault-handler": [
             "no-sandbox",
             "requires-network",

npm/private/test/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@aspect_rules_js//js:defs.bzl", "js_test")
+load("@aspect_rules_js//js:defs.bzl", "js_binary", "js_image_layer", "js_run_binary", "js_test")
 load("@bazel_lib//lib:write_source_files.bzl", "write_source_files")
 load("@bazel_skylib//rules:build_test.bzl", "build_test")
 load("@npm//:defs.bzl", "npm_link_all_packages")
@@ -120,3 +120,89 @@ js_test(
     data = [":node_modules"],
     entry_point = "versions.js",
 )
+
+# A node binary indirectly depending on a platform specific optional npm package
+js_binary(
+    name = "esbuild_entry",
+    testonly = True,
+    data = [":node_modules/esbuild"],
+    entry_point = "esbuild.js",
+)
+
+# Use a node binary consuming an optional npm package to build a file
+js_run_binary(
+    name = "versions_esbundled",
+    testonly = True,
+    srcs = [
+        "versions.js",
+        ":node_modules/lodash",
+        ":node_modules/lodash-4.17.21",
+        ":node_modules/lodash-4.17.21-tar",
+    ],
+    outs = ["versions_bundled_out.js"],
+    args = [
+        "$(location versions.js)",
+        package_name() + "/versions_bundled_out.js",
+    ],
+    tool = ":esbuild_entry",
+)
+
+# A test simply running the compiled bundle
+js_test(
+    name = "esbuilt_binary_test",
+    entry_point = "versions_bundled_out.js",
+)
+
+# A binary version of the compiled bundle
+js_binary(
+    name = "esbuilt_binary",
+    testonly = True,
+    entry_point = "versions_bundled_out.js",
+)
+
+platform(
+    name = "amd64_linux",
+    constraint_values = [
+        "@platforms//os:linux",
+        "@platforms//cpu:x86_64",
+    ],
+)
+
+platform(
+    name = "amd64_macos",
+    constraint_values = [
+        "@platforms//os:macos",
+        "@platforms//cpu:x86_64",
+    ],
+)
+
+# The compiled bundle in a platform specific container image layer
+js_image_layer(
+    name = "esbuilt_binary_image_linux",
+    testonly = True,
+    binary = ":esbuilt_binary",
+    platform = ":amd64_linux",
+)
+
+js_image_layer(
+    name = "esbuilt_binary_image_macos",
+    testonly = True,
+    binary = ":esbuilt_binary",
+    platform = ":amd64_macos",
+)
+
+build_test(
+    name = "esbuild_test",
+    targets = [
+        # The esbuild npm package including lifecycle hooks to verify platform deps
+        ":node_modules/esbuild",
+
+        # The bundle target and its output which required running esbuild
+        ":versions_esbundled",
+        "versions_bundled_out.js",
+
+        # Transitioned images using the bundle. Should still consume the original esbuild binary.
+        ":esbuilt_binary_image_linux",
+        ":esbuilt_binary_image_macos",
+    ],
+)

npm/private/test/esbuild.js

@@ -0,0 +1,15 @@
+// A simple wrapper around esbuild accepting 1 input file and 2 output file argument.
+
+const [, , input, output] = process.argv
+
+console.error('[ESBUILD] ', input, ' -> ', output)
+
+require('esbuild')
+    .build({
+        entryPoints: [input],
+        outfile: output,
+        bundle: true,
+        platform: 'node',
+        target: 'node14',
+    })
+    .catch(() => process.exit(1))

npm/private/test/package.json

@@ -15,7 +15,7 @@
         "@plotly/regl": "2.1.2",
         "bufferutil": "4.0.8",
         "debug": "ngokevin/debug#9742c5f383a6f8046241920156236ade8ec30d53",
-        "esbuild": "0.24.0",
+        "esbuild": "0.27.3",
         "handlebars-helpers/helper-date": "github:coda/helper-date#a2cb4284148cbba7d36173dff4c7c60ce59eae55",
         "hot-shots": "10.0.0",
         "inline-fixtures": "https://registry.yarnpkg.com/inline-fixtures/-/inline-fixtures-1.1.0.tgz#5f9edf644ac02a1322012dbbb9f0a4739831d662",