feat: pin Pocket DS virtual keyboard to lower display - #195
Closed
pacoa-kdbg wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for the PR. Marking as blocked because we are waiting on some architectural changes in #194. |
Member
|
im pretty sure this can be closed, the screen should be pinning on the pocket ds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DSI-2.Related pull requests
DSI-1(top) /DSI-2(bottom) mapping.ARMADA_VIRTUAL_KEYBOARD_CONNECTOR.After #160 and #194 are included in an image built with #194’s
build_patched_kwinoption, Plasma will pin Pocket DS’s virtual keyboard to the bottomDSI-2display instead of following the active-output heuristic.Test plan
bash tests/pocket-ds-virtual-keyboard-test.shfor test_file in tests/*-test.sh; do bash "$test_file"; donegit diff --check