[For dual-display devices] Pin virtual keyboard to the bottom screen - #194
Conversation
There was a problem hiding this comment.
Hey all,
I do like the changes here. But I believe we should package kwin just like we package the other components in armada-packages instead of in the base repo.
Also - I feel we shouldn't be using built-time flags to manage things like if the image should ship with components specific to the thor. Ideally we would ship one image that everyone can consume and use per-device configs to manage the differences.
The expected structure would therefore be:
- an
armada-packagesPR that builds and publishes the patched KWin package; - this
armadaPR updated to consume that package; - the per-device
ARMADA_VIRTUAL_KEYBOARD_CONNECTORconfiguration retained here.
I’m requesting changes rather than closing this, since the feature itself looks useful and the existing PR can be reworked around that packaging model.
7e8e847 to
fe6b0ee
Compare
|
Great idea @JPyke3 ! I wasn't aware of the existence of https://github.com/armada-os/armada-packages, and I love the idea of it. It honestly also makes my life easier if and when I choose to upstream this feature to KWin itself. PR updated. Tested on real device with an image built from fe6b0ee. |
|
Thank you @JPyke3 ! This is my first merged PR to this repo. I'm elated. |
Summary
This configures Armada to consume a patched KWin package and use per-device configuration to pin Plasma's virtual keyboard to a specific display connector.
On dual-screen handhelds such as the AYN Thor, the intended behavior is for the on-screen keyboard to appear on the bottom display instead of following KWin's active-output heuristic. The Thor device config sets:
The Plasma session exports that device setting before starting KWin. Devices that leave the setting empty keep upstream KWin's current active-output behavior.
Tested with an AYN Thor:
Package Dependency
Per review feedback, the KWin patch has been moved to
armada-packages: armada-os/armada-packages#22 . This PR now consumes the KWin package image instead of rebuilding KWin inside the Armada base image.Warning
The current
KWIN_PKGvalue uses:latestuntil the package PR publishes a digest that can be pinned here.Testing