Skip to content

Fix button focus background issue for twenty twenty-one theme #8698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikunj8866 wants to merge 2 commits into
base: trunk
Choose a base branch
from
+4 −0
Open

Fix button focus background issue for twenty twenty-one theme #8698

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea1fcfe
Fix button focus background issue for twenty twety-one theme
Apr 16, 2025
5b4c373
Remove extra semi colon
Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/wp-content/themes/twentytwentyone/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1990,6 +1990,10 @@ input[type=reset]:disabled,
color: currentColor;
}

.wp-block-cover .wp-block-cover__inner-container a:focus:not(.wp-block-button__link):not(.wp-block-file__button) {
background: var(--global--color-black);
Copy link
Copy Markdown
Member

@SirLouen SirLouen May 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recommend using --global--color-black

2021 was the last non-block theme. --global-color global settings is a variable introduced in 5.8, for theme.json and 2021 was introduced in 5.6.

I would simply switch to a plain color.

Copy link
Copy Markdown
Author

@nikunj8866 nikunj8866 May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SirLouen

Thank you for the feedback.

I’ve reviewed the theme, and I don’t see any instance where the --global--color custom property is defined. If there's a specific location where this appears, please let me know and I’ll be happy to investigate further.

}

.wp-block-cover .wp-block-cover__inner-container .has-link-color a,
.wp-block-cover .wp-block-cover-image-text .has-link-color a,
.wp-block-cover .wp-block-cover-text .has-link-color a,
Expand Down
Loading