Skip to content

Fix button focus background issue for twenty twenty-one theme#8698

Open
nikunj8866 wants to merge 2 commits intoWordPress:trunkfrom
nikunj8866:63291-twenty-wwenty-one-theme-button-text-not-show
Open

Fix button focus background issue for twenty twenty-one theme#8698
nikunj8866 wants to merge 2 commits intoWordPress:trunkfrom
nikunj8866:63291-twenty-wwenty-one-theme-button-text-not-show

Conversation

@nikunj8866
Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/63291


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @[email protected].

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shanemuir, nikunj8866.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@nikunj8866 nikunj8866 changed the title Fix button focus background issue for twenty twety-one theme Fix button focus background issue for twenty twenty-one theme Apr 16, 2025
@nikunj8866
Copy link
Copy Markdown
Author

nikunj8866 commented Apr 16, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @[email protected].

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Please use @nikunj8866 WordPress account.

@nikunj8866
Copy link
Copy Markdown
Author

After Fix

image

Comment thread src/wp-content/themes/twentytwentyone/style.css Outdated
@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@nikunj8866 nikunj8866 requested a review from ShaneMuir April 16, 2025 08:12
}

.wp-block-cover .wp-block-cover__inner-container a:focus:not(.wp-block-button__link):not(.wp-block-file__button) {
background: var(--global--color-black);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recommend using --global--color-black

2021 was the last non-block theme. --global-color global settings is a variable introduced in 5.8, for theme.json and 2021 was introduced in 5.6.

I would simply switch to a plain color.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SirLouen

Thank you for the feedback.

I’ve reviewed the theme, and I don’t see any instance where the --global--color custom property is defined. If there's a specific location where this appears, please let me know and I’ll be happy to investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants