Fix button focus background issue for twenty twenty-one theme#8698
Fix button focus background issue for twenty twenty-one theme#8698nikunj8866 wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @[email protected]. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Please use @nikunj8866 WordPress account. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| } | ||
|
|
||
| .wp-block-cover .wp-block-cover__inner-container a:focus:not(.wp-block-button__link):not(.wp-block-file__button) { | ||
| background: var(--global--color-black); |
There was a problem hiding this comment.
I don't recommend using --global--color-black
2021 was the last non-block theme. --global-color global settings is a variable introduced in 5.8, for theme.json and 2021 was introduced in 5.6.
I would simply switch to a plain color.
There was a problem hiding this comment.
Thank you for the feedback.
I’ve reviewed the theme, and I don’t see any instance where the --global--color custom property is defined. If there's a specific location where this appears, please let me know and I’ll be happy to investigate further.

Trac ticket: https://core.trac.wordpress.org/ticket/63291
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.