Use comment status and type to set $maybe_notify default#10489
Open
adamsilverstein wants to merge 11 commits intoWordPress:trunkfrom
Open
Use comment status and type to set $maybe_notify default#10489adamsilverstein wants to merge 11 commits intoWordPress:trunkfrom
adamsilverstein wants to merge 11 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
westonruter
reviewed
Nov 7, 2025
aaronjorbin
reviewed
Nov 10, 2025
Co-authored-by: Aaron Jorbin <[email protected]>
adamsilverstein
force-pushed
the
fix/notification-filter-default
branch
from
b823913 to
87f55c9
Compare
Co-authored-by: Weston Ruter <[email protected]>
adamsilverstein
force-pushed
the
fix/notification-filter-default
branch
from
87f55c9 to
7c217dd
Compare
westonruter
reviewed
Feb 25, 2026
Co-authored-by: Weston Ruter <[email protected]>
westonruter
reviewed
Feb 26, 2026
westonruter
reviewed
Feb 26, 2026
Co-authored-by: Weston Ruter <[email protected]>
The get_comment() return value is filtered, so reassign $comment_id from the comment object to ensure consistency between the property checks and subsequent function calls. Also removes a redundant null check on $comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/64217
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.