Skip to content
Open
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/cyan-glasses-own.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@sap-ux/adp-tooling": patch
"@sap-ux/generator-adp": patch
---

fix: Translation texts for Add Data Source and SAPUI5 Model title and subtitle
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"missingIconOrTitleOrSubtitle": "At least one of the Title, Subtitle, or Icon fields must have a value.",
"fileDoesNotExist": "This file does not exist.",
"annotationFileAlreadyExists": "There is already an annotation file with the same name. Please choose another file or rename the file and select it again.",
"errorDuplicatedValueOData": "An OData annotation or service with the same name was already added to the project. Rename and try again.",
"errorDuplicatedValueOData": "Data Source and SAPUI5 model with the same name were already added to the project. Rename and try again.",
Comment thread
mmilko01 marked this conversation as resolved.
Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"errorDuplicatedValueOData": "Data Source and SAPUI5 model with the same name were already added to the project. Rename and try again.",
"errorDuplicatedValueOData": "A data source and SAPUI5 model with the same name were already added to the project. Rename and try again.",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in: 6922d07

"errorDuplicatedValueSapui5Model": "An SAPUI5 model with the same name was already added to the project. Rename and try again.",
"errorDuplicateValueComponentId": "A component usage with the same name was already added to the project. Rename and try again.",
"errorDuplicateValueLibrary": "A library with the same name was already added to the project. Rename and try again.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ describe('getPrompts', () => {

expect(typeof validation).toBe('function');
expect(validation?.('customer.testName')).toBe(
'An OData annotation or service with the same name was already added to the project. Rename and try again.'
'Data Source and SAPUI5 model with the same name were already added to the project. Rename and try again.'
);
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"deployConfigDescr": "Configure deployment settings.",
"addComponentUsagesName": "Add SAPUI5 Component Usages",
"addComponentUsagesDescr": "Select SAPUI5 component usages.",
"addNewModelName": "Add Datasource and SAPUI5 Model",
"addNewModelDescr": "Select a Datasource and SAPUI5 model.",
"addNewModelName": "Add Data Source and SAPUI5 Model",
"addNewModelDescr": "Select a Data Source and SAPUI5 model.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"addNewModelDescr": "Select a Data Source and SAPUI5 model.",
"addNewModelDescr": "Select a data source and SAPUI5 model.",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in: 682e87d

"addLocalAnnotationFileName": "Add Local Annotation File",
"addLocalAnnotationFileDescr": "Select an OData service and annotation XML file.",
"replaceODataServiceName": "Replace OData Service",
Expand Down
2 changes: 1 addition & 1 deletion packages/generator-adp/src/types.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export enum GeneratorTypes {
ADD_ANNOTATIONS_TO_DATA = 'Add Local Annotation File',
ADD_COMPONENT_USAGES = 'Add SAPUI5 Component Usages',
ADD_NEW_MODEL = 'Add Datasource and SAPUI5 Model',
ADD_NEW_MODEL = 'Add Data Source and SAPUI5 Model',
CHANGE_DATA_SOURCE = 'Replace OData Service'
}

Expand Down
Loading