fix: Translation texts for Add Data Source and SAPUI5 Model title and subtitle#4573
fix: Translation texts for Add Data Source and SAPUI5 Model title and subtitle#4573
Conversation
🦋 Changeset detectedLatest commit: 68afc9c The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mmilko01
changed the title
mmilko01
changed the title
SummaryThe following content is AI-generated and provides a summary of the pull request: Fix: Translation Texts for "Add Data Source and SAPUI5 Model" Title, Subtitle, and Validation MessageBug Fix🐛 Corrected a spelling error in the title and subtitle of the "Add Data Source and SAPUI5 Model" generator (was incorrectly spelled as "Add Datasource and SAPUI5 Model"). Also updated the validation error message for duplicate data source and model names to be more accurate and relevant. Changes
GitHub Issues
PR Bot InformationVersion:
💌 Have ideas or want to contribute? Create an issue and share your thoughts with us! Made with ❤️ by Hyperspace. |
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
There was a problem hiding this comment.
The PR is a clean, focused text correction — fixing "Datasource" → "Data Source" in display strings, updating the errorDuplicatedValueOData validation message to be more descriptive, and keeping the test in sync. The changes are consistent across the i18n files, enum, and test. The only pre-existing issue noted is the "Cloud Foundary" typo in the deploy section, but that is unrelated to the lines changed in this PR and was flagged incorrectly on line 73 (the wrong location). Overall the PR is well-scoped and the changes are correct.
PR Bot Information
Version: 1.20.11 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback
nikmace
left a comment
nikmace
left a comment
There was a problem hiding this comment.
Changes look good
Coverage is good
Changeset is OK
Did not test manually
| "fileDoesNotExist": "This file does not exist.", | ||
| "annotationFileAlreadyExists": "There is already an annotation file with the same name. Please choose another file or rename the file and select it again.", | ||
| "errorDuplicatedValueOData": "An OData annotation or service with the same name was already added to the project. Rename and try again.", | ||
| "errorDuplicatedValueOData": "Data Source and SAPUI5 model with the same name were already added to the project. Rename and try again.", |
There was a problem hiding this comment.
| "errorDuplicatedValueOData": "Data Source and SAPUI5 model with the same name were already added to the project. Rename and try again.", | |
| "errorDuplicatedValueOData": "A data source and SAPUI5 model with the same name were already added to the project. Rename and try again.", |
| "addNewModelName": "Add Datasource and SAPUI5 Model", | ||
| "addNewModelDescr": "Select a Datasource and SAPUI5 model.", | ||
| "addNewModelName": "Add Data Source and SAPUI5 Model", | ||
| "addNewModelDescr": "Select a Data Source and SAPUI5 model.", |
There was a problem hiding this comment.
| "addNewModelDescr": "Select a Data Source and SAPUI5 model.", | |
| "addNewModelDescr": "Select a data source and SAPUI5 model.", |
Co-authored-by: Louise Findlay <[email protected]>
Co-authored-by: Louise Findlay <[email protected]>
|
3 participants
#4577
Data Source and SAPUI5 model nameprompt