Skip to content

RE1-T115 Fixing broken tts docker#365

Merged
ucswift merged 1 commit intomasterfrom
develop
May 4, 2026
Merged

RE1-T115 Fixing broken tts docker#365
ucswift merged 1 commit intomasterfrom
develop

Conversation

@ucswift
Copy link
Copy Markdown
Member

@ucswift ucswift commented May 4, 2026

Summary by CodeRabbit

  • Chores
    • Updated deployment configuration for improved voice model handling and system library management.

@request-info
Copy link
Copy Markdown

request-info Bot commented May 4, 2026

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f5093cf9-a4d1-4777-b3df-07ae0daa700a

📥 Commits

Reviewing files that changed from the base of the PR and between 0eb6906 and 42f6b61.

📒 Files selected for processing (1)
  • Web/Resgrid.Web.Tts/Dockerfile

📝 Walkthrough

Walkthrough

The Dockerfile for the Resgrid TTS service now copies the Piper phoneme library (libpiper_phonemize.so*) from the build context into the final image's library directory and refreshes the dynamic linker cache via ldconfig before proceeding with cleanup and voice-model downloads.

Changes

Piper Phoneme Library Integration

Layer / File(s) Summary
Docker Build Configuration
Web/Resgrid.Web.Tts/Dockerfile
In the final stage RUN block, copy libpiper_phonemize.so* files from /tmp/piper to /usr/local/lib and execute ldconfig to update the dynamic linker cache.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Resgrid/Core#364: Modifies the same Dockerfile to handle Piper TTS release artifacts (PIPER_VERSION and download URL changes).
  • Resgrid/Core#360: Also modifies the Dockerfile to alter the final image's runtime setup with additional TTS-related libraries and linker updates.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: fixing a broken TTS (text-to-speech) Docker configuration by adding library copying and ldconfig steps to the Dockerfile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ucswift
Copy link
Copy Markdown
Member Author

ucswift commented May 4, 2026

Approve

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit 37058d4 into master May 4, 2026
19 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant