Skip to content

RE1-T115 TTS fix#367

Merged
ucswift merged 1 commit intomasterfrom
develop
May 5, 2026
Merged

RE1-T115 TTS fix#367
ucswift merged 1 commit intomasterfrom
develop

Conversation

@ucswift
Copy link
Copy Markdown
Member

@ucswift ucswift commented May 5, 2026

Summary by CodeRabbit

Release Notes

  • Chores
    • Enhanced speech synthesis data support in the runtime environment.

@request-info
Copy link
Copy Markdown

request-info Bot commented May 5, 2026

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3d961345-fa1d-4d3e-9dc5-343bf56ee513

📥 Commits

Reviewing files that changed from the base of the PR and between dd4ce86 and 2bc40ea.

📒 Files selected for processing (1)
  • Web/Resgrid.Web.Tts/Dockerfile

📝 Walkthrough

Walkthrough

The Dockerfile for the TTS (Text-To-Speech) service is updated to install the espeak-ng-data package in addition to libespeak-ng1 during the final runtime stage, providing speech synthesis data files to the container image.

Changes

Dockerfile Runtime Dependencies

Layer / File(s) Summary
Runtime Package Dependencies
Web/Resgrid.Web.Tts/Dockerfile
The apt-get install command in the final stage now includes espeak-ng-data alongside libespeak-ng1 to provide speech synthesis data files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Resgrid/Core#360: Both PRs modify the TTS Dockerfile to change which packages are installed in the final runtime image.
  • Resgrid/Core#365: Both PRs modify the TTS Dockerfile's final stage to adjust TTS runtime dependencies.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'RE1-T115 TTS fix' references a ticket number but lacks specificity about what the fix entails. While it indicates a TTS (text-to-speech) fix, it doesn't clearly describe the actual change being made to the Dockerfile. Consider a more descriptive title like 'Add espeak-ng-data package to TTS Docker image' to clearly convey the specific change without requiring knowledge of the ticket number.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ucswift
Copy link
Copy Markdown
Member Author

ucswift commented May 5, 2026

Approve

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit 9bb4fe4 into master May 5, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant