-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat:progressive compact #3240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chejinge
wants to merge
5
commits into
OpenAtomFoundation:3.5
Choose a base branch
from
chejinge:OBDcompact
base: 3.5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat:progressive compact #3240
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,9 @@ | |
|
|
||
| #include "src/redis.h" | ||
| #include <sstream> | ||
| #include "rocksdb/db.h" | ||
| #include "rocksdb/compaction_job_stats.h" | ||
| #include "glog/logging.h" // 确保LOG宏可用 | ||
|
|
||
| namespace storage { | ||
|
|
||
|
|
@@ -196,7 +199,67 @@ void Redis::SetCompactRangeOptions(const bool is_canceled) { | |
| default_compact_range_options_.canceled = new std::atomic<bool>(is_canceled); | ||
| } else { | ||
| default_compact_range_options_.canceled->store(is_canceled); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| uint64_t Redis::TableFileNameToNumber(const std::string& name) { | ||
| uint64_t number = 0; | ||
| uint64_t base = 1; | ||
| int pos = static_cast<int>(name.find_last_of('.')); | ||
| while (--pos >= 0 && name[pos] >= '0' && name[pos] <= '9') { | ||
| number += (name[pos] - '0') * base; | ||
| base *= 10; | ||
| } | ||
| return number; | ||
| } | ||
|
|
||
| Status Redis::CompactOldFiles() { | ||
| Status s; | ||
| std::vector<rocksdb::ColumnFamilyHandle*> compact_handles_; | ||
| for (auto handle : handles_) { | ||
| compact_handles_.push_back(handle); | ||
| } | ||
| if (handles_.empty()) { | ||
| compact_handles_.push_back(db_->DefaultColumnFamily()); | ||
| } | ||
| for (auto handle : compact_handles_) { | ||
| int rate = 0; | ||
| while (rate < 70) { | ||
| rate = 100; | ||
| rocksdb::ColumnFamilyMetaData meta; | ||
| rocksdb::CompactionOptions compact_options_; | ||
| std::vector<std::string> input_file_names; | ||
| db_->GetColumnFamilyMetaData(handle, &meta); | ||
| uint64_t min_number = -1; | ||
| int min_level = 0; | ||
| std::string min_file = "999999.sst"; | ||
| std::string file_path; | ||
| for (auto level_meta : meta.levels) { | ||
| for (auto file_meta : level_meta.files) { | ||
| file_path = file_meta.db_path; | ||
| uint64_t number = 0; | ||
| number = TableFileNameToNumber(file_meta.name); | ||
| if (number < min_number) { | ||
| min_file = file_meta.name; | ||
| min_level = level_meta.level; | ||
| min_number = number; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if (min_level < 6) min_level++; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. L0层的文件是不是交给后台自动处理比较好? L6文件的处理IO我觉得相对也比较高,我这边的策略是不处理,交给低峰期的全量compact(正在测试中) |
||
|
|
||
| if (min_file != "999999.sst") { | ||
| input_file_names.push_back(min_file); | ||
| rocksdb::CompactionJobInfo job_info; | ||
| db_->CompactFiles(compact_options_, handle, input_file_names, min_level, -1, nullptr, &job_info); | ||
| LOG(WARNING) << "CompactFiles: " << handle->GetName()<< " : " << file_path << " : " << min_file << " : " << min_level << ", job_stats : " << job_info.stats.num_input_records << ": "<< job_info.stats.num_output_records; | ||
| if (job_info.stats.num_input_records == 0) { break; } | ||
| rate = job_info.stats.num_output_records * 100 / job_info.stats.num_input_records; | ||
| } | ||
| } | ||
| } | ||
| return s; | ||
| } | ||
|
|
||
| } // namespace storage | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个写法看着有点特别,是为了让渐进式支持动态开关么?