Skip to content

feat:progressive compact#3240

Open
chejinge wants to merge 5 commits intoOpenAtomFoundation:3.5from
chejinge:OBDcompact
Open

feat:progressive compact#3240
chejinge wants to merge 5 commits intoOpenAtomFoundation:3.5from
chejinge:OBDcompact

Conversation

@chejinge
Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 53aa8290-c020-4569-8ea1-b21bc97a4441

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the ✏️ Feature New feature or request label Apr 15, 2026
@chejinge chejinge requested review from Mixficsol and chenbt-hz April 16, 2026 02:20
DoCompactRange(task.type, task.argv.front(), task.argv.back());
}
} else if (task.operation == kCompactSST) {
DoCompactOldFiles(task.type);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这俩是不是写反了?

enum BeforeOrAfter { Before, After };

enum DataType { kAll, kStrings, kHashes, kLists, kZSets, kSets, kStreams };
enum DataType { kAll, kStrings, kHashes, kLists, kZSets, kSets, kStreams, kSST };
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个写法看着有点特别,是为了让渐进式支持动态开关么?

Comment thread src/storage/src/redis.cc
}
}

if (min_level < 6) min_level++;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L0层的文件是不是交给后台自动处理比较好? L6文件的处理IO我觉得相对也比较高,我这边的策略是不处理,交给低峰期的全量compact(正在测试中)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✏️ Feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants