Skip to content

test(validation): unmount wrappers to fix pending fetch errors #7020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitormattos merged 1 commit into from
Feb 26, 2026
Merged

test(validation): unmount wrappers to fix pending fetch errors #7020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/tests/views/Validation.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,10 @@ describe('Validation.vue - Business Logic', () => {
})
})

afterEach(() => {
wrapper.unmount()
})

describe('canValidate computed property', () => {
it('returns false when uuidToValidate is empty', () => {
wrapper.setData({ uuidToValidate: '' })
Expand Down Expand Up @@ -520,6 +524,7 @@ describe('Validation.vue - Business Logic', () => {
describe('created() - async signing activation from history.state', () => {
const UUID = '550e8400-e29b-41d4-a716-446655440000'
let stateGetter: ReturnType<typeof vi.spyOn>
let localWrapper: ReturnType<typeof shallowMount> | null = null

beforeEach(() => {
// Prevent the validate() floating Promise from crashing on
Expand All @@ -528,6 +533,8 @@ describe('Validation.vue - Business Logic', () => {
})

afterEach(() => {
localWrapper?.unmount()
localWrapper = null
stateGetter?.mockRestore()
vi.mocked(axios.get).mockReset()
})
Expand All @@ -539,7 +546,7 @@ describe('Validation.vue - Business Logic', () => {
// This test verifies the OLD trigger (route params) no longer activates async signing.
it('does NOT set isAsyncSigning via $route.params (Vue Router 5 drops non-path params)', () => {
stateGetter = vi.spyOn(window.history, 'state', 'get').mockReturnValue({} as any)
const localWrapper = shallowMount(Validation, {
localWrapper = shallowMount(Validation, {
mocks: {
$route: { params: { uuid: UUID, isAsync: true }, query: {} },
$router: { ...mockRouter, replace: vi.fn() },
Expand All @@ -553,7 +560,7 @@ describe('Validation.vue - Business Logic', () => {

it('does not set isAsyncSigning when history.state has no isAsync flag', () => {
stateGetter = vi.spyOn(window.history, 'state', 'get').mockReturnValue({} as any)
const localWrapper = shallowMount(Validation, {
localWrapper = shallowMount(Validation, {
mocks: {
$route: { params: { uuid: UUID }, query: {} },
$router: { ...mockRouter, replace: vi.fn() },
Expand Down Expand Up @@ -606,14 +613,15 @@ describe('Validation.vue - Business Logic', () => {
})

it('does not fire confetti when document is not signed even if isAfterSigned is true', () => {
const localWrapper = shallowMount(Validation, {
const lw = shallowMount(Validation, {
mocks: {
$route: { params: { isAfterSigned: true }, query: {} },
$router: mockRouter,
},
})
localWrapper.vm.handleValidationSuccess({ status: 1, signers: [] })
lw.vm.handleValidationSuccess({ status: 1, signers: [] })
expect(mockAddConfetti).not.toHaveBeenCalled()
lw.unmount()
})

it('does not fire confetti when document is signed but neither isAfterSigned nor shouldFireAsyncConfetti is true', () => {
Expand Down
Loading