test(validation): unmount wrappers to fix pending fetch errors#7020
Merged
vitormattos merged 1 commit intomainfrom Feb 26, 2026
Merged
test(validation): unmount wrappers to fix pending fetch errors#7020vitormattos merged 1 commit intomainfrom
vitormattos merged 1 commit intomainfrom
Conversation
Vitest was reporting 13 unhandled rejections with 'Closing rpc while fetch was pending' in Validation.spec.ts. Root cause: Vue instances were never unmounted between tests, so their beforeUnmount hooks never ran — isActiveView stayed true and background microtasks (validate, refreshAfterAsyncSigning) kept firing after the worker started winding down. Fixes: - Add outer afterEach(() => wrapper.unmount()) for the main wrapper - Track local wrappers in the created() describe at scope level and unmount them in afterEach - Unmount the inline localWrapper in the handleValidationSuccess describe immediately after use Signed-off-by: Vitor Mattos <[email protected]>
Member
Author
|
/backport to stable33 |
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
Member
Author
|
/backport to stable32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.