Skip to content

refactor: Replace Bullet component with NcChip and fix signer reactivity #6134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitormattos merged 1 commit into from
Dec 11, 2025
Merged

refactor: Replace Bullet component with NcChip and fix signer reactivity #6134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions src/Components/Bullet/Bullet.vue
View file
Open in desktop

This file was deleted.

13 changes: 7 additions & 6 deletions src/Components/Signers/Signer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@
</template>
<template #subname>
<div class="signer-subname">
<Bullet v-for="method in identifyMethodsNames" :key="method" :name="method" />
<NcChip v-for="method in identifyMethodsNames"
:key="method"
:text="method"
:no-close="true" />
<NcChip :text="signer.statusText"
:type="chipType"
:icon-path="statusIconPath"
Expand Down Expand Up @@ -48,8 +51,6 @@ import NcAvatar from '@nextcloud/vue/components/NcAvatar'
import NcChip from '@nextcloud/vue/components/NcChip'
import NcListItem from '@nextcloud/vue/components/NcListItem'

import Bullet from '../Bullet/Bullet.vue'

import { useFilesStore } from '../../store/files.js'

export default {
Expand All @@ -59,10 +60,9 @@ export default {
NcAvatar,
NcChip,
DragVertical,
Bullet,
},
props: {
currentSigner: {
signerIndex: {
type: Number,
required: true,
},
Expand Down Expand Up @@ -94,7 +94,8 @@ export default {
},
computed: {
signer() {
return this.filesStore.getFile().signers[this.currentSigner]
const file = this.filesStore.getFile()
return file?.signers?.[this.signerIndex]
},
signerName() {
return this.signer.displayName
Expand Down
4 changes: 2 additions & 2 deletions src/Components/Signers/Signers.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<transition-group name="signer-list" tag="div">
<Signer v-for="(signer, index) in sortableSigners"
:key="signer.identify || index"
:current-signer="index"
:signer-index="index"
:event="event"
:draggable="!signer.signed">
<template #actions="{closeActions}">
Expand All @@ -27,7 +27,7 @@
<ul v-else>
<Signer v-for="(signer, index) in signers"
:key="signer.identify || index"
:current-signer="index"
:signer-index="index"
:event="event">
<template #actions="{closeActions}">
<slot name="actions" :signer="signer" :closeActions="closeActions" />
Expand Down