Skip to content

refactor: Replace Bullet component with NcChip and fix signer reactivity#6134

Merged
vitormattos merged 1 commit intomainfrom
refactor/replace-bullet-with-ncchip
Dec 11, 2025
Merged

refactor: Replace Bullet component with NcChip and fix signer reactivity#6134
vitormattos merged 1 commit intomainfrom
refactor/replace-bullet-with-ncchip

Conversation

@vitormattos
Copy link
Copy Markdown
Member

  • Replace custom Bullet component with NcChip from @nextcloud/vue
  • Remove unused Bullet component
  • Fix reactivity issue by passing signerIndex instead of currentSigner
  • Signer component now fetches data from store reactively using computed property
  • This ensures changes in store are properly reflected in the UI

- Replace custom Bullet component with NcChip from @nextcloud/vue
- Remove unused Bullet component
- Fix reactivity issue by passing signerIndex instead of currentSigner
- Signer component now fetches data from store reactively using computed property
- This ensures changes in store are properly reflected in the UI

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos added this to the Next Major (33) milestone Dec 11, 2025
@vitormattos vitormattos self-assigned this Dec 11, 2025
@github-project-automation github-project-automation Bot moved this to 0. Needs triage in Roadmap Dec 11, 2025
@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable32

@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable31

@vitormattos vitormattos merged commit 309794b into main Dec 11, 2025
32 checks passed
@vitormattos vitormattos deleted the refactor/replace-bullet-with-ncchip branch December 11, 2025 19:21
@github-project-automation github-project-automation Bot moved this from 0. Needs triage to 4. to release in Roadmap Dec 11, 2025
@backportbot-libresign
Copy link
Copy Markdown

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/6134/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3f061158

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6134/stable32

Error: Failed to push branch backport/6134/stable32: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable32

@backportbot-libresign
Copy link
Copy Markdown

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/6134/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3f061158

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6134/stable32

Error: Failed to push branch backport/6134/stable32: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant