refactor: organize enums in dedicated folder#6100
Merged
vitormattos merged 2 commits intomainfrom Dec 11, 2025
Merged
Conversation
Move SignRequestStatus from lib/Db/ to lib/Enum/ to follow project convention of keeping all enums in a dedicated folder alongside CRLStatus, CRLReason, CertificateType, and DocMdpLevel. Updated namespace from OCA\Libresign\Db to OCA\Libresign\Enum and adjusted all imports and references across: - SignRequest entity (added import) - ValidateHelper (updated FQN references) - RequestSignatureService (updated FQN references) - SequentialSigningService (updated import) - SignFileService (updated FQN reference) This improves code organization by consolidating all enum types in one location. Signed-off-by: Vitor Mattos <[email protected]>
Move SignatureFlow from lib/Service/ to lib/Enum/ to centralize all enum definitions in the same location following project structure conventions. Updated namespace from OCA\Libresign\Service to OCA\Libresign\Enum and adjusted all imports and references across: - AdminController (updated FQN references for from() and comparison) - PageController (updated FQN reference) - TemplateLoader (updated FQN reference) - Settings/Admin (updated import statement) - SequentialSigningService (added explicit import) This completes the consolidation of enum types, making the codebase more organized and easier to maintain. Signed-off-by: Vitor Mattos <[email protected]>
vitormattos
force-pushed
the
refactor/organize-enums-in-dedicated-folder
branch
from
159e100 to
3a55587
Compare
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
github-project-automation
Bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This was referenced Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.