Merge pull request #6100 from LibreSign/refactor/organize-enums-in-dedicated-folder

refactor: organize enums in dedicated folder

Author: vitormattos

lib/Controller/AdminController.php

@@ -908,15 +908,15 @@ public function footerTemplatePreviewPdf(string $template = '', int $width = 595
 	#[ApiRoute(verb: 'POST', url: '/api/{apiVersion}/admin/signature-flow/config', requirements: ['apiVersion' => '(v1)'])]
 	public function setSignatureFlowConfig(string $mode): DataResponse {
 		try {
-			$signatureFlow = \OCA\Libresign\Service\SignatureFlow::from($mode);
+			$signatureFlow = \OCA\Libresign\Enum\SignatureFlow::from($mode);
 		} catch (\ValueError) {
 			return new DataResponse([
 				'error' => $this->l10n->t('Invalid signature flow mode. Use "parallel" or "ordered_numeric".'),
 			], Http::STATUS_BAD_REQUEST);
 		}
 
 		try {
-			if ($signatureFlow === \OCA\Libresign\Service\SignatureFlow::PARALLEL) {
+			if ($signatureFlow === \OCA\Libresign\Enum\SignatureFlow::PARALLEL) {
 				$this->appConfig->deleteKey(Application::APP_ID, 'signature_flow');
 			} else {
 				$this->appConfig->setValueString(

lib/Controller/PageController.php

@@ -95,7 +95,7 @@ public function index(): TemplateResponse {
 
 		$this->provideSignerSignatues();
 		$this->initialState->provideInitialState('identify_methods', $this->identifyMethodService->getIdentifyMethodsSettings());
-		$this->initialState->provideInitialState('signature_flow', $this->appConfig->getValueString(Application::APP_ID, 'signature_flow', \OCA\Libresign\Service\SignatureFlow::PARALLEL->value));
+		$this->initialState->provideInitialState('signature_flow', $this->appConfig->getValueString(Application::APP_ID, 'signature_flow', \OCA\Libresign\Enum\SignatureFlow::PARALLEL->value));
 		$this->initialState->provideInitialState('legal_information', $this->appConfig->getValueString(Application::APP_ID, 'legal_information'));
 
 		Util::addScript(Application::APP_ID, 'libresign-main');

lib/Db/SignRequest.php

@@ -8,6 +8,7 @@
 
 namespace OCA\Libresign\Db;
 
+use OCA\Libresign\Enum\SignRequestStatus;
 use OCP\AppFramework\Db\Entity;
 use OCP\DB\Types;
 

lib/Db/SignRequestStatus.php lib/Enum/SignRequestStatus.phplib/Db/SignRequestStatus.php renamed to lib/Enum/SignRequestStatus.php

@@ -1,12 +1,13 @@
 <?php
 
 declare(strict_types=1);
+
 /**
  * SPDX-FileCopyrightText: 2025 LibreCode coop and contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-namespace OCA\Libresign\Db;
+namespace OCA\Libresign\Enum;
 
 enum SignRequestStatus: int {
 	case DRAFT = 0;

lib/Service/SignatureFlow.php lib/Enum/SignatureFlow.phplib/Service/SignatureFlow.php renamed to lib/Enum/SignatureFlow.php

@@ -1,12 +1,13 @@
 <?php
 
 declare(strict_types=1);
+
 /**
  * SPDX-FileCopyrightText: 2025 LibreCode coop and contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-namespace OCA\Libresign\Service;
+namespace OCA\Libresign\Enum;
 
 /**
  * Signature flow modes

lib/Files/TemplateLoader.php

@@ -60,7 +60,7 @@ public function handle(Event $event): void {
 
 		$this->initialState->provideInitialState(
 			'signature_flow',
-			$this->appConfig->getValueString(Application::APP_ID, 'signature_flow', \OCA\Libresign\Service\SignatureFlow::PARALLEL->value)
+			$this->appConfig->getValueString(Application::APP_ID, 'signature_flow', \OCA\Libresign\Enum\SignatureFlow::PARALLEL->value)
 		);
 
 		try {

lib/Helper/ValidateHelper.php

@@ -720,14 +720,14 @@ private function validateSignerStatus(string $uuid): void {
 		$signRequest = $this->signRequestMapper->getByUuid($uuid);
 		$status = $signRequest->getStatusEnum();
 
-		if ($status === \OCA\Libresign\Db\SignRequestStatus::DRAFT) {
+		if ($status === \OCA\Libresign\Enum\SignRequestStatus::DRAFT) {
 			throw new LibresignException(json_encode([
 				'action' => JSActions::ACTION_DO_NOTHING,
 				'errors' => [['message' => $this->l10n->t('You are not allowed to sign this document yet')]],
 			]));
 		}
 
-		if ($status === \OCA\Libresign\Db\SignRequestStatus::SIGNED) {
+		if ($status === \OCA\Libresign\Enum\SignRequestStatus::SIGNED) {
 			throw new LibresignException(json_encode([
 				'action' => JSActions::ACTION_DO_NOTHING,
 				'errors' => [['message' => $this->l10n->t('Document already signed')]],

lib/Service/RequestSignatureService.php

@@ -267,14 +267,14 @@ private function associateToSigner(
 		$isNewSignRequest = !$signRequest->getId();
 		$currentStatus = $signRequest->getStatusEnum();
 
-		if ($isNewSignRequest || $currentStatus === \OCA\Libresign\Db\SignRequestStatus::DRAFT) {
+		if ($isNewSignRequest || $currentStatus === \OCA\Libresign\Enum\SignRequestStatus::DRAFT) {
 			$initialStatus = $this->determineInitialStatus($signingOrder);
 			$signRequest->setStatusEnum($initialStatus);
 		}
 
 		$this->saveSignRequest($signRequest);
 
-		$shouldNotify = $notify && $signRequest->getStatusEnum() === \OCA\Libresign\Db\SignRequestStatus::ABLE_TO_SIGN;
+		$shouldNotify = $notify && $signRequest->getStatusEnum() === \OCA\Libresign\Enum\SignRequestStatus::ABLE_TO_SIGN;
 
 		foreach ($identifyMethodsIncances as $identifyMethod) {
 			$identifyMethod->getEntity()->setSignRequestId($signRequest->getId());
@@ -284,14 +284,14 @@ private function associateToSigner(
 		return $signRequest;
 	}
 
-	private function determineInitialStatus(int $signingOrder): \OCA\Libresign\Db\SignRequestStatus {
+	private function determineInitialStatus(int $signingOrder): \OCA\Libresign\Enum\SignRequestStatus {
 		if (!$this->sequentialSigningService->isOrderedNumericFlow()) {
-			return \OCA\Libresign\Db\SignRequestStatus::ABLE_TO_SIGN;
+			return \OCA\Libresign\Enum\SignRequestStatus::ABLE_TO_SIGN;
 		}
 
 		return $signingOrder === 1
-			? \OCA\Libresign\Db\SignRequestStatus::ABLE_TO_SIGN
-			: \OCA\Libresign\Db\SignRequestStatus::DRAFT;
+			? \OCA\Libresign\Enum\SignRequestStatus::ABLE_TO_SIGN
+			: \OCA\Libresign\Enum\SignRequestStatus::DRAFT;
 	}
 
 	/**

lib/Service/SequentialSigningService.php

@@ -10,7 +10,8 @@
 
 use OCA\Libresign\AppInfo\Application;
 use OCA\Libresign\Db\SignRequestMapper;
-use OCA\Libresign\Db\SignRequestStatus;
+use OCA\Libresign\Enum\SignatureFlow;
+use OCA\Libresign\Enum\SignRequestStatus;
 use OCP\IAppConfig;
 
 class SequentialSigningService {

lib/Service/SignFileService.php

@@ -376,7 +376,7 @@ protected function updateSignRequest(string $hash): void {
 		$lastSignedDate = $this->getEngine()->getLastSignedDate();
 		$this->signRequest->setSigned($lastSignedDate);
 		$this->signRequest->setSignedHash($hash);
-		$this->signRequest->setStatusEnum(\OCA\Libresign\Db\SignRequestStatus::SIGNED);
+		$this->signRequest->setStatusEnum(\OCA\Libresign\Enum\SignRequestStatus::SIGNED);
 
 		$this->signRequestMapper->update($this->signRequest);